fix: redirect the user to the home directory if dir is not set (coder#6085)

kylecarbs · web-flow · commit f6effdb63e2a · 2023-02-07T20:28:41.000Z
This was blocking SSH connections from being established if a dir
that wasn't created yet is set.
diff --git a/agent/agent.go b/agent/agent.go
@@ -803,7 +803,11 @@ func (a *agent) createCommand(ctx context.Context, rawCommand string, env []stri
 
 	cmd := exec.CommandContext(ctx, shell, args...)
 	cmd.Dir = metadata.Directory
-	if cmd.Dir == "" {
+
+	// If the metadata directory doesn't exist, we run the command
+	// in the users home directory.
+	_, err = os.Stat(cmd.Dir)
+	if cmd.Dir == "" || err != nil {
 		// Default to user home if a directory is not set.
 		homedir, err := userHomeDir()
 		if err != nil {
