Update models.py #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a backward compatible import where the warning is removed for django1.8 and ensure that the project will run on Django1.9 when the support for GenericForeignKey will be removed from the generic module in contenttype.
|
@vinitkumar thanks! I've merged in the changes from upstream (the StreetVoice repo). Closing this PR, but let me know if there's anything more I can do. |
|
@hwkns Thanks for merging the changes. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a backward compatible import where the warning is
removed for django1.8 and ensure that the project will run on Django1.9
when the support for GenericForeignKey will be removed from the generic
module in contenttype.
Please add this fix. This fix has already been merged to the master repo. StreetVoice#9. We use your work on production and require these changes to be merged so that it works on Django1.9 and above.