Release the native window after window gets closed

zcbenz · zcbenz · commit e3c64d79716f · 2015-09-17T11:30:17.000+08:00
Previously we delete the window after the JS object gets garbage
collected, which is too late for releasing some resources.
diff --git a/atom/browser/api/atom_api_window.cc b/atom/browser/api/atom_api_window.cc
@@ -116,6 +116,9 @@ void Window::OnWindowClosed() {
   window_->RemoveObserver(this);
 
   Emit("closed");
+
+  // Clean up the resources after window has been closed.
+  base::MessageLoop::current()->DeleteSoon(FROM_HERE, window_.release());
 }
 
 void Window::OnWindowBlur() {

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,9 @@ void Window::OnWindowClosed() {`
`116`	`116`	`window_->RemoveObserver(this);`
`117`	`117`
`118`	`118`	`Emit("closed");`
	`119`	`+`
	`120`	`+ // Clean up the resources after window has been closed.`
	`121`	`+ base::MessageLoop::current()->DeleteSoon(FROM_HERE, window_.release());`
`119`	`122`	`}`
`120`	`123`
`121`	`124`	`void Window::OnWindowBlur() {`