wip: rough alignment of moon eclipse works

opatiny · opatiny · commit c60d56cd347b · 2024-01-26T17:38:16.000+01:00
diff --git a/scripts/alignStack/testAlignStack.ts b/scripts/alignStack/testAlignStack.ts
@@ -10,7 +10,6 @@ import { crop, writeSync } from '../../src';
 const folder = `${__dirname}/BloodMoon`;
 let imageNames = readdirSync(folder);
 
-imageNames = imageNames.slice(0, 2);
 console.log(imageNames);
 
 const paths = imageNames.map((name) => `${folder}/${name}`);
@@ -26,7 +25,7 @@ console.log(
 console.log('Compute absolute translations');
 const translations = alignStack(stack, {
   debug: true,
-  scalingFactor: 150,
+  scalingFactor: 20,
 });
 
 console.log('Cropping all images');
diff --git a/src/stack/align/utils/getMinDiffTranslation.ts b/src/stack/align/utils/getMinDiffTranslation.ts
@@ -36,9 +36,9 @@ export function getMinDiffTranslation(
 
   const maxRow = destination.height - source.height + topBottomMargin;
   const maxColumn = destination.width - source.width + leftRightMargin;
-
-  const nbTranslations = (maxRow + 1) * (maxColumn + 1);
-  console.log({ nbTranslations: (maxRow + 1) * (maxColumn + 1) });
+  const nbTranslations =
+    (maxRow + 2 * topBottomMargin) * (maxColumn + 2 * leftRightMargin);
+  console.log({ nbTranslations });
 
   let minDiff = Number.MAX_SAFE_INTEGER;
   let minDiffTranslation: Point = { row: 0, column: 0 };
@@ -55,8 +55,12 @@ export function getMinDiffTranslation(
         minDiff = diff;
         minDiffTranslation = translation;
       }
+      console.log(
+        `translation ${
+          row * (maxRow + topBottomMargin) + column
+        } / ${nbTranslations}`,
+      );
     }
   }
-  console.log({ minDiff, minDiffTranslation });
   return minDiffTranslation;
 }
diff --git a/src/stack/align/utils/getNormalisedDifference.ts b/src/stack/align/utils/getNormalisedDifference.ts
@@ -105,12 +105,7 @@ export function getNormalisedDifference(
           )
         ) {
           pixelCounted = true;
-          if (
-            sourceTranslation.column === 15 &&
-            sourceTranslation.row === -12
-          ) {
-            console.log({ column, row, channel });
-          }
+
           const sourceValue = source.getValue(
             column + sourceXOffet,
             row + sourceYOffset,
@@ -142,8 +137,6 @@ export function getNormalisedDifference(
     // If there are not enough pixels overlapping, we consider the difference to be maximal
     return 2 ** source.bitDepth - 1;
   }
-  if (sourceTranslation.column === 15 && sourceTranslation.row === -12) {
-    console.log({ nbPixels, diff: difference / nbPixels });
-  }
+
   return difference / nbPixels;
 }

Original file line number	Diff line number	Diff line change
`@@ -36,9 +36,9 @@ export function getMinDiffTranslation(`
`36`	`36`
`37`	`37`	`const maxRow = destination.height - source.height + topBottomMargin;`
`38`	`38`	`const maxColumn = destination.width - source.width + leftRightMargin;`
`39`		`-`
`40`		`- const nbTranslations = (maxRow + 1) * (maxColumn + 1);`
`41`		`- console.log({ nbTranslations: (maxRow + 1) * (maxColumn + 1) });`
	`39`	`+ const nbTranslations =`
	`40`	`+ (maxRow + 2 * topBottomMargin) * (maxColumn + 2 * leftRightMargin);`
	`41`	`+ console.log({ nbTranslations });`
`42`	`42`
`43`	`43`	`let minDiff = Number.MAX_SAFE_INTEGER;`
`44`	`44`	`let minDiffTranslation: Point = { row: 0, column: 0 };`
`@@ -55,8 +55,12 @@ export function getMinDiffTranslation(`
`55`	`55`	`minDiff = diff;`
`56`	`56`	`minDiffTranslation = translation;`
`57`	`57`	`}`
	`58`	`+ console.log(`
	`59`	+ `translation ${
	`60`	`+ row * (maxRow + topBottomMargin) + column`
	`61`	+ } / ${nbTranslations}`,
	`62`	`+ );`
`58`	`63`	`}`
`59`	`64`	`}`
`60`		`- console.log({ minDiff, minDiffTranslation });`
`61`	`65`	`return minDiffTranslation;`
`62`	`66`	`}`