Skip to content

resize method doesn't work properly #452

New issue
New issue
Open
Open
resize method doesn't work properly#452
Labels
bugSomething isn't working
@targos

Description

@targos
targos
opened on Apr 26, 2024

It somehow "zooms" in the image. This is especially visible on the nearest-neighbor version of the test.

There's probably a bug in how we iterate on the pixels.
Implementation: https://github.com/image-js/image-js-typescript/blob/main/src/geometry/resize.ts#L55-L86

We need to fix it so these tests can be enabled:

image-js-typescript/src/geometry/__tests__/resize.test.ts

Lines 3 to 21 in 8d81c2b

test.skip('compare result of resize with opencv (nearest)', () => {
const img = testUtils.load('opencv/test.png');
const resized = img.resize({
xFactor: 10,
yFactor: 10,
interpolationType: 'nearest',
});
expect(resized).toMatchImage('opencv/testResizeNearest.png');
});
test.skip('compare result of resize with opencv (bilinear)', () => {
const img = testUtils.load('opencv/test.png');
const resized = img.resize({
xFactor: 10,
yFactor: 10,
});

Reference created by

image-js-typescript/test/img/opencv/generate.py

Lines 15 to 19 in 8d81c2b

# Image resizing by 10.
dst = cv.resize(img, (80, 100), interpolation=cv.INTER_NEAREST)
cv.imwrite('testResizeNearest.png', dst)
dst = cv.resize(img, (80, 100), interpolation=cv.INTER_LINEAR)
cv.imwrite('testResizeBilinear.png', dst)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions