Rollback sideEffects implementation

jdeniau · jdeniau · commit 339ef9ecfe97 · 2023-08-28T12:18:56.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,12 @@ Dates are formatted as YYYY-MM-DD.
 
 ## Unreleased
 
+## [5.0.0-beta.3]
+
+Remove tree-shaking possibility as it does break. Moreover, as nearly every collection type can be converted to another collection (`Map().toList()` for example), so nearly no code was removed.
+
+I think that if we want to implement this, we might need to rethink this functionality.
+
 ## [5.0.0-beta.2]
 
 Merge `main` branch into `5.x` for [4.3.4](https://github.com/immutable-js/immutable-js/releases/tag/v4.3.4) fixes.
@@ -16,10 +22,9 @@ Merge `main` branch into `5.x` for [4.3.4](https://github.com/immutable-js/immut
 
 ### Changed
 
-### [Minor BC break] Reducing file size / tree shaking
+### [Minor BC break] Remove default export
 
 Immutable does not export a default object containing all it's API anymore.
-It changes the output of your JS file if you use a bundler that supports tree-shaking (all modern bundler do).
 As a drawback, you can not `immport Immutable` directly:
 
 ```diff
@@ -157,7 +162,6 @@ For now, only `get`, `getIn`, `set`, `update`, `delete`, `remove`, `toJS`, `toJS
 
 ## [4.1.0] - 2022-05-23
 
-- [BREAKING] The ES6 bundle no longer exposes a default export, which allows bundlers to apply tree-shaking. [#1888](https://github.com/immutable-js/immutable-js/pull/1888) by [bdurrer](https://github.com/bdurrer)
 - Accept Symbol as Map key. [#1859](https://github.com/immutable-js/immutable-js/pull/1859) by [jdeniau](https://github.com/jdeniau)
 - Optimize contructors without arguments [#1887](https://github.com/immutable-js/immutable-js/pull/1887) by [marianoguerra](https://github.com/marianoguerra)
 - Fix Flow removeIn types [#1902](https://github.com/immutable-js/immutable-js/pull/1902) by [nifgraup](https://github.com/nifgraup)
diff --git a/package.json b/package.json
@@ -18,9 +18,6 @@
   "main": "dist/immutable.js",
   "module": "dist/es/Immutable.js",
   "types": "dist/immutable.d.ts",
-  "sideEffects": [
-    "./src/CollectionImpl.js"
-  ],
   "files": [
     "dist",
     "README.md",
@@ -142,13 +139,13 @@
       "name": "List",
       "path": "dist/es/Immutable.js",
       "import": "{ List }",
-      "limit": "12 kB"
+      "limit": "20 kB"
     },
     {
       "name": "Seq",
       "path": "dist/es/Immutable.js",
       "import": "{ Seq }",
-      "limit": "2 kB"
+      "limit": "20 kB"
     }
   ]
 }
