Fix Repeat(<value>).equals(undefined) incorrectly returning true (#1994)

butchler · web-flow · commit be3cb9a7ae9a · 2024-05-10T12:13:39.000+02:00
* Add failing test case for Repeat(&lt;value&gt;).equals(undefined)

* Fix Repeat(&lt;value&gt;).equals(undefined) incorrectly returning true
diff --git a/__tests__/Repeat.ts b/__tests__/Repeat.ts
@@ -11,4 +11,8 @@ describe('Repeat', () => {
     expect(v.toArray()).toEqual(['wtf', 'wtf', 'wtf']);
     expect(v.join()).toEqual('wtf,wtf,wtf');
   });
+
+  it('does not claim to be equal to undefined', () => {
+    expect(Repeat(1).equals(undefined)).toEqual(false);
+  });
 });
diff --git a/src/Repeat.js b/src/Repeat.js
@@ -93,7 +93,7 @@ export class Repeat extends IndexedSeq {
   equals(other) {
     return other instanceof Repeat
       ? is(this._value, other._value)
-      : deepEqual(other);
+      : deepEqual(this, other);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ export class Repeat extends IndexedSeq {`
`93`	`93`	`equals(other) {`
`94`	`94`	`return other instanceof Repeat`
`95`	`95`	`? is(this._value, other._value)`
`96`		`- : deepEqual(other);`
	`96`	`+ : deepEqual(this, other);`
`97`	`97`	`}`
`98`	`98`	`}`
`99`	`99`