Use default tsconfig for tests

jdeniau · jdeniau · commit e497f82ffc87 · 2025-03-22T21:41:50.000Z
diff --git a/__tests__/Conversion.ts b/__tests__/Conversion.ts
@@ -114,7 +114,7 @@ describe('Conversion', () => {
   });
 
   it('Converts deep JSON with custom conversion', () => {
-    const seq = fromJS(js, function (key, sequence) {
+    const seq = fromJS(js, function (this, key, sequence) {
       if (key === 'point') {
         // @ts-expect-error -- to convert to real typing
         return new Point(sequence);
@@ -130,13 +130,17 @@ describe('Conversion', () => {
   it('Converts deep JSON with custom conversion including keypath if requested', () => {
     const paths: Array<Array<string | number> | undefined> = [];
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const seq1 = fromJS(js, function (key, sequence, keypath) {
-      expect(arguments.length).toBe(3);
-      paths.push(keypath);
-      return Array.isArray(this[key])
-        ? sequence.toList()
-        : sequence.toOrderedMap();
-    });
+    const seq1 = fromJS(
+      js,
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      function (this: typeof js, key: any, sequence, keypath) {
+        expect(arguments.length).toBe(3);
+        paths.push(keypath);
+        return Array.isArray(this[key])
+          ? sequence.toList()
+          : sequence.toOrderedMap();
+      }
+    );
     expect(paths).toEqual([
       [],
       ['deepList'],
diff --git a/__tests__/KeyedSeq.ts b/__tests__/KeyedSeq.ts
@@ -1,5 +1,6 @@
 import { Range, Seq } from 'immutable';
 import * as jasmineCheck from 'jasmine-check';
+import invariant from '../src/utils/invariant';
 
 jasmineCheck.install();
 
@@ -36,6 +37,10 @@ describe('KeyedSeq', () => {
     const [indexed0, indexed1] = seq
       .partition(isEven)
       .map((part) => part.skip(10).take(5));
+
+    invariant(indexed0, 'indexed0 is not undefined');
+    invariant(indexed1, 'indexed0 is not undefined');
+
     expect(indexed0.entrySeq().toArray()).toEqual([
       [0, 21],
       [1, 23],
@@ -64,6 +69,10 @@ describe('KeyedSeq', () => {
     const [keyed0, keyed1] = keyed
       .partition(isEven)
       .map((part) => part.skip(10).take(5));
+
+    invariant(keyed0, 'keyed0 is not undefined');
+    invariant(keyed1, 'keyed1 is not undefined');
+
     expect(keyed0.entrySeq().toArray()).toEqual([
       [21, 21],
       [23, 23],
diff --git a/__tests__/Map.ts b/__tests__/Map.ts
@@ -449,7 +449,7 @@ describe('Map', () => {
 
   it('uses toString on keys and values', () => {
     class A extends Record({ x: null as number | null }) {
-      toString() {
+      override toString() {
         return this.x;
       }
     }
diff --git a/__tests__/Seq.ts b/__tests__/Seq.ts
@@ -38,7 +38,7 @@ describe('Seq', () => {
   });
 
   it('accepts arbitrary objects', () => {
-    function Foo() {
+    function Foo(this: { bar: string; baz: string }) {
       this.bar = 'bar';
       this.baz = 'baz';
     }
diff --git a/__tests__/Set.ts b/__tests__/Set.ts
@@ -304,7 +304,7 @@ describe('Set', () => {
         Symbol('a'),
         Symbol('b'),
         Symbol('c'),
-      ];
+      ] as const;
 
       const symbolSet = Set(manySymbols);
       expect(symbolSet.size).toBe(12);
diff --git a/__tests__/merge.ts b/__tests__/merge.ts
@@ -241,15 +241,18 @@ describe('merge', () => {
     ).toBe(true);
   });
 
-  const map = { type: 'Map', value: Map({ b: 5, c: 9 }) };
-  const object = { type: 'object', value: { b: 7, d: 12 } };
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+  type TypeValue = { type: any; value: any };
+
+  const map: TypeValue = { type: 'Map', value: Map({ b: 5, c: 9 }) };
+  const object: TypeValue = { type: 'object', value: { b: 7, d: 12 } };
   const RecordFactory = Record({ a: 1, b: 2 });
-  const record = { type: 'Record', value: RecordFactory({ b: 3 }) };
-  const list = { type: 'List', value: List(['5']) };
-  const array = { type: 'array', value: ['9'] };
-  const set = { type: 'Set', value: Set('3') };
+  const record: TypeValue = { type: 'Record', value: RecordFactory({ b: 3 }) };
+  const list: TypeValue = { type: 'List', value: List(['5']) };
+  const array: TypeValue = { type: 'array', value: ['9'] };
+  const set: TypeValue = { type: 'Set', value: Set('3') };
 
-  const incompatibleTypes = [
+  const incompatibleTypes: Array<[TypeValue, TypeValue]> = [
     [map, list],
     [map, array],
     [map, set],
diff --git a/__tests__/tsconfig.json b/__tests__/tsconfig.json
@@ -1,12 +1,9 @@
 {
+  "extends": "../tsconfig.json",
   "compilerOptions": {
-    "noEmit": true,
-    // TODO: add additional strictness
-    "strictNullChecks": true,
-    "strictFunctionTypes": true,
-    "target": "esnext",
-    "moduleResolution": "node",
-    "skipLibCheck": true,
+    // TODO remove those "false" value that make the code less strict
+    "noImplicitAny": false,
+    "verbatimModuleSyntax": false,
     "paths": {
       "immutable": ["../type-definitions/immutable.d.ts"],
       "jasmine-check": ["../resources/jasmine-check.d.ts"]
diff --git a/resources/jestPreprocessor.js b/resources/jestPreprocessor.js
@@ -3,11 +3,11 @@ const makeSynchronous = require('make-synchronous');
 
 const TYPESCRIPT_OPTIONS = {
   noEmitOnError: true,
-  target: typescript.ScriptTarget.ES2015,
+  target: typescript.ScriptTarget.ES2022,
   module: typescript.ModuleKind.CommonJS,
-  strictNullChecks: true,
   sourceMap: true,
   inlineSourceMap: true,
+  esModuleInterop: true,
 };
 
 function transpileTypeScript(src, path) {

Original file line number	Diff line number	Diff line change
`@@ -449,7 +449,7 @@ describe('Map', () => {`
`449`	`449`
`450`	`450`	`it('uses toString on keys and values', () => {`
`451`	`451`	`class A extends Record({ x: null as number \| null }) {`
`452`		`- toString() {`
	`452`	`+ override toString() {`
`453`	`453`	`return this.x;`
`454`	`454`	`}`
`455`	`455`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ describe('Seq', () => {`
`38`	`38`	`});`
`39`	`39`
`40`	`40`	`it('accepts arbitrary objects', () => {`
`41`		`- function Foo() {`
	`41`	`+ function Foo(this: { bar: string; baz: string }) {`
`42`	`42`	`this.bar = 'bar';`
`43`	`43`	`this.baz = 'baz';`
`44`	`44`	`}`