Call super()" before this in constructors (#2077)

jdeniau · web-flow · commit ef6bc430e6c5 · 2025-03-25T23:11:20.000+01:00
* Call super()" before this in constructors

* Fix issue with MapIterator re-setting the next method
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -27,13 +27,11 @@ export default tseslint.config(
   {
     rules: {
       eqeqeq: 'error',
-      'constructor-super': 'off',
       'no-constructor-return': 'error',
       'no-else-return': 'error',
       'no-lonely-if': 'error',
       'no-object-constructor': 'error',
       'no-prototype-builtins': 'off',
-      'no-this-before-super': 'off',
       'no-useless-concat': 'error',
       'no-var': 'error',
       'operator-assignment': 'error',
diff --git a/src/Iterator.js b/src/Iterator.js
@@ -9,7 +9,10 @@ export const ITERATOR_SYMBOL = REAL_ITERATOR_SYMBOL || FAUX_ITERATOR_SYMBOL;
 
 export class Iterator {
   constructor(next) {
-    this.next = next;
+    if (next) {
+      // Map extends Iterator and has a `next` method, do not erase it in that case. We could have checked `if (next && !this.next)` too.
+      this.next = next;
+    }
   }
 
   toString() {
diff --git a/src/Map.js b/src/Map.js
@@ -553,6 +553,8 @@ ValueNode.prototype.iterate = function (fn, reverse) {
 
 class MapIterator extends Iterator {
   constructor(map, type, reverse) {
+    super();
+
     this._type = type;
     this._reverse = reverse;
     this._stack = map._root && mapIteratorFrame(map._root);
diff --git a/src/Operations.js b/src/Operations.js
@@ -44,6 +44,8 @@ import { OrderedMap } from './OrderedMap';
 
 export class ToKeyedSequence extends KeyedSeqImpl {
   constructor(indexed, useKeys) {
+    super();
+
     this._iter = indexed;
     this._useKeys = useKeys;
     this.size = indexed.size;
@@ -89,6 +91,8 @@ ToKeyedSequence.prototype[IS_ORDERED_SYMBOL] = true;
 
 export class ToIndexedSequence extends IndexedSeqImpl {
   constructor(iter) {
+    super();
+
     this._iter = iter;
     this.size = iter.size;
   }
@@ -128,6 +132,8 @@ export class ToIndexedSequence extends IndexedSeqImpl {
 
 export class ToSetSequence extends SetSeqImpl {
   constructor(iter) {
+    super();
+
     this._iter = iter;
     this.size = iter.size;
   }
@@ -153,6 +159,8 @@ export class ToSetSequence extends SetSeqImpl {
 
 export class FromEntriesSequence extends KeyedSeqImpl {
   constructor(entries) {
+    super();
+
     this._iter = entries;
     this.size = entries.size;
   }
@@ -597,6 +605,8 @@ export function skipWhileFactory(collection, predicate, context, useKeys) {
 
 class ConcatSeq extends SeqImpl {
   constructor(iterables) {
+    super();
+
     this._wrappedIterables = iterables.flatMap((iterable) => {
       if (iterable._wrappedIterables) {
         return iterable._wrappedIterables;
diff --git a/src/Range.js b/src/Range.js
@@ -33,6 +33,8 @@ export const Range = (start, end, step = 1) => {
 };
 export class RangeImpl extends IndexedSeqImpl {
   constructor(start, end, step, size) {
+    super();
+
     this._start = start;
     this._end = end;
     this._step = step;
diff --git a/src/Repeat.js b/src/Repeat.js
@@ -22,6 +22,8 @@ export const Repeat = (value, times) => {
 
 export class RepeatImpl extends IndexedSeqImpl {
   constructor(value, size) {
+    super();
+
     this._value = value;
     this.size = size;
   }

Original file line number	Diff line number	Diff line change
`@@ -22,6 +22,8 @@ export const Repeat = (value, times) => {`
`22`	`22`
`23`	`23`	`export class RepeatImpl extends IndexedSeqImpl {`
`24`	`24`	`constructor(value, size) {`
	`25`	`+ super();`
	`26`	`+`
`25`	`27`	`this._value = value;`
`26`	`28`	`this.size = size;`
`27`	`29`	`}`