From 44132737f8fb1a8837b0d7d934665a23a6329822 Mon Sep 17 00:00:00 2001 From: Julien Deniau Date: Fri, 8 Nov 2024 00:07:01 +0000 Subject: [PATCH 1/3] handle the fact that bundlephobia might be down --- resources/dist-stats.mjs | 37 ++++++++++++++++++++----------------- 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/resources/dist-stats.mjs b/resources/dist-stats.mjs index a63b087fdc..8605f961d7 100644 --- a/resources/dist-stats.mjs +++ b/resources/dist-stats.mjs @@ -31,8 +31,6 @@ async function bundlephobaInfo(key) { `https://bundlephobia.com/api/size?package=immutable@${VERIFY_AGAINST_VERSION}` ); - console.log(res.status); - if (res.status !== 200) { throw new Error( `Unable to fetch bundlephobia in dist-stats.mjs. Status code is "${res.status}"` @@ -50,7 +48,7 @@ async function bundlephobaInfo(key) { return bundlephobaInfoCache[key]; } -Promise.all([ +Promise.allSettled([ fs.readFile('dist/immutable.js'), fs.readFile('dist/immutable.min.js'), bundlephobaInfo('size'), @@ -59,23 +57,28 @@ Promise.all([ ]) .then(results => results.map(result => - typeof result === 'number' + typeof (result === null || result === 'number') ? result : Number(Buffer.byteLength(result, 'utf8')) ) ) .then(([rawNew, minNew, minOld, zipNew, zipOld]) => { - console.log(` Raw: ${space(14, bytes(rawNew).cyan)}`); - console.log( - ` Min: ${space(14, bytes(minNew).cyan)}${percentage( - minNew, - rawNew - )}${space(15, diff(minNew, minOld))}` - ); - console.log( - ` Zip: ${space(14, bytes(zipNew).cyan)}${percentage( - zipNew, - rawNew - )}${space(15, diff(zipNew, zipOld))}` - ); + console.log(` Raw: ${space(14, bytes(rawNew.value).cyan)}`); + if (minOld.status === 'fulfilled') { + console.log( + ` Min: ${space(14, bytes(minNew.value).cyan)}${percentage( + minNew.value, + rawNew.value + )}${space(15, diff(minNew.value, minOld.value))}` + ); + } + + if (zipOld.status === 'fulfilled') { + console.log( + ` Zip: ${space(14, bytes(zipNew.value).cyan)}${percentage( + zipNew.value, + rawNew.value + )}${space(15, diff(zipNew.value, zipOld.value))}` + ); + } }); From a2e2f96de90d74168264c6c722431a1fbf541738 Mon Sep 17 00:00:00 2001 From: Julien Deniau Date: Fri, 8 Nov 2024 00:13:21 +0000 Subject: [PATCH 2/3] fix path to es version --- package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 194472b006..8dbc5b80eb 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "url": "https://github.com/immutable-js/immutable-js/issues" }, "main": "dist/immutable.js", - "module": "dist/es/Immutable.js", + "module": "dist/immutable.es.js", "types": "dist/immutable.d.ts", "files": [ "dist", @@ -133,19 +133,19 @@ "size-limit": [ { "name": "all", - "path": "dist/es/Immutable.js", + "path": "dist/immutable.es.js", "import": "*", "limit": "20 kB" }, { "name": "List", - "path": "dist/es/Immutable.js", + "path": "dist/immutable.es.js", "import": "{ List }", "limit": "20 kB" }, { "name": "Seq", - "path": "dist/es/Immutable.js", + "path": "dist/immutable.es.js", "import": "{ Seq }", "limit": "20 kB" } From 879f42893cebbad6fcf4fad5425c408ac08a57b5 Mon Sep 17 00:00:00 2001 From: Julien Deniau Date: Fri, 8 Nov 2024 00:13:30 +0000 Subject: [PATCH 3/3] 5.0.2 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index fea4d2709f..6592666323 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "immutable", - "version": "5.0.1", + "version": "5.0.2", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "immutable", - "version": "5.0.1", + "version": "5.0.2", "license": "MIT", "devDependencies": { "@rollup/plugin-buble": "1.0.2", diff --git a/package.json b/package.json index 8dbc5b80eb..d27ae6bd5b 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "immutable", - "version": "5.0.1", + "version": "5.0.2", "description": "Immutable Data Collections", "license": "MIT", "homepage": "https://immutable-js.com",