Skip to content

Request: Move TypeScript definition to DefinitelyTyped #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KSXGitHub opened this issue Dec 7, 2018 · 1 comment
Closed

Request: Move TypeScript definition to DefinitelyTyped #1660

KSXGitHub opened this issue Dec 7, 2018 · 1 comment

Comments

@KSXGitHub
Copy link
Contributor

KSXGitHub commented Dec 7, 2018

When I was trying to improve type inference of fromJS, I encountered a problem: My definition requires newer version of TypeScript, but when I tried to upgrade, I got a bunch of errors, most of those are linting errors (which can be fixed) but some of them are runtime errors caused by the tools themselves (e.g. dtslint failed to download TypeScript 3.x, gulp failed to run in Node.js 11, and serveral Uncaught TypeError caused by tslint). I tried to fix them all, but to no avail.

For that reason, I suggest removing TypeScript definitions from this repo and add them to DefinitelyTyped as the people there are more familiar with TypeScript. I'm also more familiar with that repo.

@jdeniau
Copy link
Member

jdeniau commented Oct 16, 2021

Typescript definition has improved a lot in 4.0.0 that is out now.
Please re-open this if there is still an issue on the subject.

@jdeniau jdeniau closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants