Skip to content

FYI - immutable-js ported to Deno #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oguimbal opened this issue Nov 5, 2020 · 9 comments
Closed

FYI - immutable-js ported to Deno #1798

oguimbal opened this issue Nov 5, 2020 · 9 comments

Comments

@oguimbal
Copy link

oguimbal commented Nov 5, 2020

I ported immutable-js so it is usable in Deno.

You can find it at https://deno.land/x/immutable Let me know if you have any problem with that :)

(And thank you for this great lib !)

@jdeniau
Copy link
Member

jdeniau commented Jul 19, 2021

Hi,

Thanks for this. I do not know if this is really useful in comparaison to npmjs.
If it is, can we make the process automatic ? I don't think you want to update your fork, build, and publish every time we publish a new version here. (the 4.0.0-rc.14 is not published for example).

@oguimbal
Copy link
Author

oguimbal commented Jul 19, 2021

Hi,

You cannot use npm packages in Deno. (its module system is VERY different from that of Node).
So it is not really a matter of comparison: You dont have a choice when using Deno.

I'll think about automating it, but I dont have time these days - I'm adding that to my todolist.

In the meantime, I updated & published 4.0.0-rc.14 on deno.land (see this commit - it only takes 5 seconds for me)

@jdeniau
Copy link
Member

jdeniau commented Jul 19, 2021

OK great ! 👍

I'm closing this as user that want to search immutable on deno will find https://deno.land/x/immutable@4.0.0-rc.14-deno ! 🎉

@jdeniau jdeniau closed this as completed Jul 19, 2021
@vegerot
Copy link

vegerot commented Feb 12, 2022

I've noticed that https://deno.land/x/immutable has not been updated in a while.

Are there any plans on moving immutable-js-deno to immutable-js/immutable-js-deno or something? As well as providing automatic releases?

Also, on the note of

You cannot use npm packages in Deno. (its module system is VERY different from that of Node).

Moving immutable js to 100% esm support (by changing type in package.json to type: module) will then make immutable essentially back-and-forth compatible with Deno

@jdeniau
Copy link
Member

jdeniau commented Feb 15, 2022

Can anybody sum up what needs to be done to make immutable compatible with deno ?

@oguimbal
Copy link
Author

Hi, I publisher of https://deno.land/x/immutable here...
I could transfer ownership to owners of immutable-js if needed, just ping me 🙂

This Denoified version of immutable is just a hack (literraly 3 lines of code) that exports the js bundle of immutable-js, and its type definition.

That does the trick (or at least used to) for the Deno interpreter, so you could use as if it was an actual Typescript bundle.

I think that upgrading to a newer immutable-js should be very straightforward using the same trick.

I dont have much time to do that and test it with a newer version of Deno at the moment, but if someone is willing to do it, I'd gladly accept a pullrequest.

@jdeniau
Copy link
Member

jdeniau commented Feb 16, 2022

If this is only a matter of this single file, can we include it in the main immutable package ?
(If I remember correctly, thoses files did change and should be simpler now, no "ambiant" stuff) since #1854

@vegerot
Copy link

vegerot commented Feb 16, 2022

I don't see why not. Would make installation and updating much simpler

@oguimbal
Copy link
Author

Yes, but would have to commit the built js bundle as well, in order to make it downloadable by Deno (that's why I excluded those from .gitignore)

@uriva uriva mentioned this issue Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants