You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, big fan here, long time user, first time caller. First, let me say, sharp tools can be a pleasure to use, but I also believe workplace injuries should be reported.
what happened
Someone on my team wrote an innocent-looking component with the help of Range():
const SomeComponent = ({min, max}) => {
return <div>
<!-- more html -->
{Range(min, max).map(num => <option value={num}>{num}</option>)}
</div>
}
called it some place and moved on with their day.
Later, in a different context, rendering the above component resulted in an infinite loop that took over an hour to find. The cause, of course is that Range(undefined, undefined) or without arguments is infinite. Seems it would be safer if getting an infinite range required being more explicit.
I anticipate this may get shut down, cause like "read the docs, be careful, use typescript" and what not, but has anyone else been burned by this? Am I the first to get infinite Range unintentionally?
The text was updated successfully, but these errors were encountered:
Hey, big fan here, long time user, first time caller. First, let me say, sharp tools can be a pleasure to use, but I also believe workplace injuries should be reported.
what happened
Someone on my team wrote an innocent-looking component with the help of
Range()
:called it some place and moved on with their day.
Later, in a different context, rendering the above component resulted in an infinite loop that took over an hour to find. The cause, of course is that Range(undefined, undefined) or without arguments is infinite. Seems it would be safer if getting an infinite range required being more explicit.
I anticipate this may get shut down, cause like "read the docs, be careful, use typescript" and what not, but has anyone else been burned by this? Am I the first to get infinite Range unintentionally?
The text was updated successfully, but these errors were encountered: