Skip to content

Type predicate missing on isOrderedSet function type declaration #1947

Closed
@andyk

Description

@andyk

What happened

The type definition for the type guard function isOrderedSet inside is missing the is OrderedSet<unknown> type predicate here inside the namespace OrderedSet

function isOrderedSet(maybeOrderedSet: unknown): boolean;

The type predicated exists on the ValueObject definition of the function, as you can see here:

function isOrderedSet(
maybeOrderedSet: unknown
): maybeOrderedSet is OrderedSet<unknown>;

Seems like a small oversight and quick fix?

I checked that other guards do have the type predicate in both declarations, e.g. OrderedMap:

function isOrderedMap(
maybeOrderedMap: unknown
): maybeOrderedMap is OrderedMap<unknown, unknown>;

function isOrderedMap(
maybeOrderedMap: unknown
): maybeOrderedMap is OrderedMap<unknown, unknown>;

How to reproduce

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions