Skip to content

Consider throwing error when deep accessor used with non-array keyPath #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmnd opened this issue Dec 31, 2014 · 2 comments
Closed

Consider throwing error when deep accessor used with non-array keyPath #269

dmnd opened this issue Dec 31, 2014 · 2 comments

Comments

@dmnd
Copy link

dmnd commented Dec 31, 2014

I constantly seem to make this mistake: foo.getIn("bar", "baz"). (note the lack of [])

Often it returns undefined but sometimes I end up with a number or something. The annoying thing is that the error is silent. I wish getIn would just blow up when I try to do something like that.
@leebyron
Copy link
Collaborator

Closing as a dupe of #256 but thanks for the reminder to release a minor version on npm soon.

@dmnd
Copy link
Author

dmnd commented Dec 31, 2014

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmnd @leebyron