Skip to content

Modernification Master Task #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
12 of 15 tasks
leebyron opened this issue Jan 5, 2016 · 5 comments
Closed
12 of 15 tasks

Modernification Master Task #742

leebyron opened this issue Jan 5, 2016 · 5 comments

Comments

@leebyron
Copy link
Collaborator

leebyron commented Jan 5, 2016

Immutable.js's tools are behind the times and it is limiting progress on some of the top line goals.

This is a master task that details all the steps required to modernize the repository.

@avocadowastaken
Copy link
Contributor

avocadowastaken commented Mar 5, 2017

I also suggest to add prettier and yarn to the list.

This was referenced Mar 5, 2017
@avocadowastaken
Copy link
Contributor

avocadowastaken commented Mar 7, 2017

As I said in #1096 (comment)

And first problem.

According to the spec - es6 classes can not be called as a functions.

Few solutions:

Make a breaking change and disalow var map = Map() syntax in favor of var map = new Map().
Refactor all es6 classes to Function.prototype style.
Keep using declassify (but first - need to fix it for latest rollup).


Oh, spec changed, now i'll try Bublé tonight.

@leebyron
Copy link
Collaborator Author

leebyron commented Mar 7, 2017

Using new with collections is actually an anti pattern. They're designed to be used like the JS scalar types (Number, String) as just a callable function.

That does mean the class syntax either needs to only ever be consumed by an off-spec transformer or it needs to be converted to use MapPrototype.method = function(){} or rely on Object.create's extra properties param or something like that

@leebyron
Copy link
Collaborator Author

leebyron commented Mar 8, 2017

I think it's safe to call this task done. There's always more modernization to be done, but this hits the major objectives.

Thanks so much for your help, @umidbekkarimov!

@leebyron leebyron closed this as completed Mar 8, 2017
@avocadowastaken
Copy link
Contributor

@leebyron yep 👍 for docs need to update react, react-router and jump from gulp to webpack+webpack-dev-server. I guess it's good first bug for facebook juniors 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants