Fix issue 1915 #2038
Merged
Fix issue 1915 #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alexvictoor . Can you rebase onto the main branch ? It seems that you have included a lot of commits |
e999337 to
bbf9c32
Compare
|
I messed up a little bit with my commit but there is only one...
…On Mon, Dec 9, 2024 at 11:40 AM Julien Deniau ***@***.***> wrote:
Hi @alexvictoor <https://github.com/alexvictoor> .
Can you rebase onto the main branch ? It seems that you have included a
lot of commits
—
Reply to this email directly, view it on GitHub
<#2038 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADKXNANQ4HA565NJSSTHV32EVXTPAVCNFSM6AAAAABTIQP7LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRXGU2TCNZUGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bbf9c32 to
61d90ab
Compare
|
Sorry @jdeniau should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a fix for a 2 years old issue: #1915
Let me know if you have any question or feel some stuffs should be done differently.
Cheers