immutable-js · leebyron · Mar 26, 2015 · Mar 26, 2015 · Mar 26, 2015 · Mar 26, 2015
diff --git a/.gitignore b/.gitignore
@@ -6,3 +6,4 @@ npm-debug.log
 *~
 *.swp
 TODO
+build
diff --git a/Gruntfile.js b/Gruntfile.js
@@ -203,17 +203,6 @@ module.exports = function(grunt) {
     });
   });
 
-  grunt.registerTask('init_ts_compiler', function () {
-    // LOL. This is because requiring ts-compiler for the first time actually
-    // calls fs.writeFileSync(), which when called from within a parallel
-    // test-runner, freaks out the file system and fails. This is pretty
-    // poor-form from TypeScript. The solution is to first require ts-compiler
-    // from this main process, before our test runner can access it, so
-    // fs.writeFileSync() has an opportunity to succeed.
-    var ts = require('ts-compiler');
-  });
-
-
   grunt.loadNpmTasks('grunt-contrib-jshint');
   grunt.loadNpmTasks('grunt-contrib-copy');
   grunt.loadNpmTasks('grunt-contrib-clean');
@@ -222,6 +211,6 @@ module.exports = function(grunt) {
 
   grunt.registerTask('lint', 'Lint all source javascript', ['jshint']);
   grunt.registerTask('build', 'Build distributed javascript', ['clean', 'bundle', 'copy']);
-  grunt.registerTask('test', 'Test built javascript', ['init_ts_compiler', 'jest']);
+  grunt.registerTask('test', 'Test built javascript', ['jest']);
   grunt.registerTask('default', 'Lint, build and test.', ['lint', 'build', 'stats', 'test']);
 }
diff --git a/__tests__/flatten.ts b/__tests__/flatten.ts
@@ -8,6 +8,8 @@ import I = require('immutable');
 import jasmineCheck = require('jasmine-check');
 jasmineCheck.install();
 
+type SeqType = number | number[] | I.Iterable<number,number>;
+
 describe('flatten', () => {
 
   it('flattens sequences one level deep', () => {
@@ -29,13 +31,13 @@ describe('flatten', () => {
   })
 
   it('flattens only Sequences (not sequenceables)', () => {
-    var nested = I.Seq.of(I.Range(1,3),[3,4],I.List.of(5,6,7),8);
+    var nested = I.Seq.of<SeqType>(I.Range(1,3),[3,4],I.List.of(5,6,7),8);
     var flat = nested.flatten();
     expect(flat.toJS()).toEqual([1,2,[3,4],5,6,7,8]);
   })
 
   it('can be reversed', () => {
-    var nested = I.Seq.of(I.Range(1,3),[3,4],I.List.of(5,6,7),8);
+    var nested = I.Seq.of<SeqType>(I.Range(1,3),[3,4],I.List.of(5,6,7),8);
     var flat = nested.flatten();
     var reversed = flat.reverse();
     expect(reversed.toJS()).toEqual([8,7,6,5,[3,4],2,1]);

diff --git a/__tests__/slice.ts b/__tests__/slice.ts
@@ -31,7 +31,7 @@ describe('slice', () => {
   it('slices a sparse indexed sequence', () => {
     expect(Seq([1,,2,,3,,4,,5,,6]).slice(1).toArray()).toEqual([,2,,3,,4,,5,,6]);
     expect(Seq([1,,2,,3,,4,,5,,6]).slice(2).toArray()).toEqual([2,,3,,4,,5,,6]);
-    expect(Seq([1,,2,,3,,4,,5,,6]).slice(3, -3).toArray()).toEqual([,3,,4,,,]); // one trailing hole.
+    expect(Seq([1,,2,,3,,4,,5,,6]).slice(3, -3).toArray()).toEqual([,3,,4,,]); // one trailing hole.
   })
 
   it('can maintain indices for an keyed indexed sequence', () => {

diff --git a/dist/immutable.d.ts b/dist/immutable.d.ts
@@ -1067,6 +1067,10 @@ declare module 'immutable' {
       new (): Map<string, any>;
       new (values: {[key: string]: any}): Map<string, any>;
       new (values: Iterable<string, any>): Map<string, any>; // deprecated
+
+      (): Map<string, any>;
+      (values: {[key: string]: any}): Map<string, any>;
+      (values: Iterable<string, any>): Map<string, any>; // deprecated
     }
   }
 

diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
     "magic-string": "^0.2.6",
     "microtime": "^1.2.0",
     "react-tools": "^0.11.1",
-    "ts-compiler": "^2.0.0",
+    "typescript": "^1.4.1",
     "uglify-js": "^2.4.15"
   },
   "engines": {
@@ -71,4 +71,4 @@
     "iteration"
   ],
   "license": "BSD"
-}
+}
diff --git a/resources/jestPreprocessor.js b/resources/jestPreprocessor.js
@@ -1,31 +1,66 @@
 // preprocessor.js
+var fs = require('fs');
 var path = require('path');
-var ts = require('ts-compiler');
+var typescript = require('typescript');
 var react = require('react-tools');
 
+var CACHE_DIR = path.join(path.resolve(__dirname + '/../build'));
+
+function isFileNewer(a, b) {
+  try {
+    return fs.statSync(a).mtime > fs.statSync(b).mtime;
+  } catch (ex) {
+    return false;
+  }
+}
+
+function compileTypeScript(filePath) {
+  var options = {
+    outDir: CACHE_DIR,
+    noEmitOnError: true,
+    target: typescript.ScriptTarget.ES5,
+    module: typescript.ModuleKind.CommonJS
+  };
+
+  // re-use cached source if possible
+  var outputPath = path.join(options.outDir, path.basename(filePath, '.ts')) + '.js';
+  if (isFileNewer(outputPath, filePath)) {
+    return fs.readFileSync(outputPath).toString();
+  }
+
+  if (fs.existsSync(outputPath)) {
+    fs.unlinkSync(outputPath);
+  }
+
+  var host = typescript.createCompilerHost(options);
+  var program = typescript.createProgram([filePath], options, host);
+  var checker = typescript.createTypeChecker(program, true /* produceDiagnostics */);
+  var result = checker.emitFiles();
+
+  var allErrors = program.getDiagnostics().concat(checker.getDiagnostics())
+    .concat(result.diagnostics);
+  allErrors.forEach(function(diagnostic) {
+    var lineChar = diagnostic.file.getLineAndCharacterFromPosition(diagnostic.start);
+    console.error('%s %d:%d %s', diagnostic.file.filename, lineChar.line, lineChar.character, diagnostic.messageText);
+  });
+
+  if (result.emitResultStatus !== typescript.EmitReturnStatus.Succeeded) {
+    throw new Error('Compiling ' + filePath + ' failed');
+  }
+
+  return fs.readFileSync(outputPath).toString();
+}
+
 module.exports = {
   process: function(src, filePath) {
     if (filePath.match(/\.ts$/) && !filePath.match(/\.d\.ts$/)) {
-      ts.compile([filePath], {
-        skipWrite: true,
-        module: 'commonjs'
-      }, function(err, results) {
-        if (err) {
-          throw err;
-        }
-        results.forEach(function(file) {
-          // This is gross, but jest doesn't provide an asynchronous way to
-          // process a module, and ts currently runs syncronously.
-          src = file.text;
-        });
-      });
-      return src;
-    }
-    if (filePath.match(/\.js$/)) {
-      return react.transform(src, {harmony: true}).replace(
-        /require\('immutable/g,
-        "require('" + path.relative(path.dirname(filePath), process.cwd())
-      );
+      return compileTypeScript(filePath);
+    } else if (filePath.match(/\.js$/)) {
+      var result = react.transform(src, {harmony: true}).replace(
+          /require\('immutable/g,
+          "require('" + path.relative(path.dirname(filePath), process.cwd())
+          );
+      return result;
     }
     return src;
   }

diff --git a/resources/node_test.sh b/resources/node_test.sh
@@ -1,8 +1,5 @@
 #!/bin/bash
 
-# Many lols. See gruntfile for full explanation.
-node -e "require('ts-compiler')"
-
 # Run all tests using jest
 if [[ $TRAVIS ]]
 then jest -i # Travis tests are run inline

diff --git a/type-definitions/Immutable.d.ts b/type-definitions/Immutable.d.ts
@@ -1067,6 +1067,10 @@ declare module 'immutable' {
       new (): Map<string, any>;
       new (values: {[key: string]: any}): Map<string, any>;
       new (values: Iterable<string, any>): Map<string, any>; // deprecated
+
+      (): Map<string, any>;
+      (values: {[key: string]: any}): Map<string, any>;
+      (values: Iterable<string, any>): Map<string, any>; // deprecated
     }
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -6,3 +6,4 @@ npm-debug.log @@
     *~
     *.swp
     TODO
+    build