make_lines omits field values with empty strings #655

rhestilow-skytap · 2018-10-31T01:06:05Z

When writing a point where one or more field values are empty strings (""), influxdb-python will omit them in the line protocol representation. If there are no non-empty fields, this will omit all fields, resulting in an invalid line protocol format and an error.

For example, the following is allowed on the influx command line interface:

> INSERT m0 value=""
> SELECT * FROM m0
name: m0
time                value
----                -----
1540946138927548393

However, the equivalent in python results in an InfluxDBClientError:

def test_client_nonempty_field_string(client):
    point = {
            "measurement": "m0",
            "fields": { "value": "foo" },
    }

    # succeeds
    client.write_points([point])

def test_client_empty_field_string(client):
    point = {
            "measurement": "m0",
            "fields": { "value": "" },
    }

    # raises InfluxDBClientError: 400: {"error":"unable to parse 'm0 ': invalid field format"}
    client.write_points([point])

This appears to be related to the None handling introduced in commit 26683a4. In that commit, a conversion from None to '' was introduced in _get_unicode, and subsequently field values == '' are filtered out in make_lines. However, if a user explicitly passes in '' for a field value, then those values will get caught in this check and be filtered out as well.

This affects version 5.2.0 and earlier, and was tested against influxdb 1.4.3. It may also be related to #549.

The text was updated successfully, but these errors were encountered:

* Fix make_lines excludes fields with empty strings (#655) Converting to unicode required something to be done with None values. They were converted to empty strings which were subsequently ignored. This makes it impossible to write an explicitly empty string, which should be possible. This change distinguishes between None and empty strings. * Fix linting failure due to long comment line Co-authored-by: Greg Schrock <gschrock@128technology.com>

sebito91 · 2020-04-10T17:31:35Z

Closed by #766

…nfluxdata#766) * Fix make_lines excludes fields with empty strings (influxdata#655) Converting to unicode required something to be done with None values. They were converted to empty strings which were subsequently ignored. This makes it impossible to write an explicitly empty string, which should be possible. This change distinguishes between None and empty strings. * Fix linting failure due to long comment line Co-authored-by: Greg Schrock <gschrock@128technology.com>

sebito91 closed this as completed Apr 10, 2020

azrdev mentioned this issue Jul 20, 2022

influxdb output: use a single measurement merbanan/rtl_433#2115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

make_lines omits field values with empty strings #655

make_lines omits field values with empty strings #655

rhestilow-skytap commented Oct 31, 2018

sebito91 commented Apr 10, 2020

Uh oh!

make_lines omits field values with empty strings #655

make_lines omits field values with empty strings #655

Comments

rhestilow-skytap commented Oct 31, 2018

sebito91 commented Apr 10, 2020

Uh oh!