From 50279bf214c3ea079759321e248c43858739370e Mon Sep 17 00:00:00 2001 From: Laurent Raufaste Date: Sat, 29 Mar 2014 22:14:52 -0400 Subject: [PATCH 1/3] InfluxDBClient() does not accept None as a host or a port --- examples/tutorial.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/tutorial.py b/examples/tutorial.py index 0e3d2f53..51abaee3 100644 --- a/examples/tutorial.py +++ b/examples/tutorial.py @@ -3,7 +3,7 @@ from influxdb import InfluxDBClient -def main(host=None, port=None): +def main(host='localhost', port=8086): user = 'root' password = 'root' dbname = 'example' From c6435c4afb070bebcc0b140d8e44d833a930b136 Mon Sep 17 00:00:00 2001 From: Laurent Raufaste Date: Sat, 29 Mar 2014 22:25:29 -0400 Subject: [PATCH 2/3] Broken query() was not building a valid url --- influxdb/client.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/influxdb/client.py b/influxdb/client.py index 8a281be4..23158c06 100644 --- a/influxdb/client.py +++ b/influxdb/client.py @@ -157,12 +157,8 @@ def query(self, query, time_precision='s', chunked=False): else: chunked_param = 'false' - url = "{0}/db/{1}/series" - - url.format( - self._baseurl, - self._database - ) + # Build the URL of the serie to query + url = "{0}/db/{1}/series".format(self._baseurl, self._database) params = { 'u': self._username, From 6452d5efbabdad039c2e9d659d31049e71184424 Mon Sep 17 00:00:00 2001 From: Laurent Raufaste Date: Sat, 29 Mar 2014 22:28:24 -0400 Subject: [PATCH 3/3] PEP8 --- tests/influxdb/client_test.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/influxdb/client_test.py b/tests/influxdb/client_test.py index cfc5fb61..a44a7b23 100644 --- a/tests/influxdb/client_test.py +++ b/tests/influxdb/client_test.py @@ -160,14 +160,16 @@ def test_get_database_list_fails(self): def test_delete_series(self): with patch.object(session, 'delete') as mocked_delete: - mocked_delete.return_value = _build_response_object(status_code=204) + mocked_delete.return_value = _build_response_object( + status_code=204) cli = InfluxDBClient('host', 8086, 'username', 'password', 'db') cli.delete_series('old_series') @raises(Exception) def test_delete_series_fails(self): with patch.object(session, 'delete') as mocked_delete: - mocked_delete.return_value = _build_response_object(status_code=401) + mocked_delete.return_value = _build_response_object( + status_code=401) cli = InfluxDBClient('host', 8086, 'username', 'password', 'db') cli.delete_series('old_series')