This repository was archived by the owner on Oct 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 524
Add CQs management methods to the client #414
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f93a9a0
to
4e42b41
Compare
@aviau seems like docs test is really broken. |
Yeah. Somebody needs to fix it. |
Can you rebase this on master? The tests should now pass. |
Yay, it is passing now. |
@smolse the logic here is completely fine, but can you please add comments to the test functions (something basic)? We've introduced PEP257 compliance over the past few weeks, and that's the only failing test at the moment. Once you've added, we can merge this. |
sebito91
suggested changes
Aug 17, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP257 compliance for test cases
sebito91
approved these changes
Apr 8, 2020
sebito91
added a commit
that referenced
this pull request
Apr 8, 2020
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
* Add CQs management methods to the client * chore(server_tests): update pep257 and flake8 commentary * chore(client_test): update comments based on pep257 and flake8 Co-authored-by: Sergei Smolianinov <sergei.smolianinov@f-secure.com> Co-authored-by: Sebastian Borza <sebito91@gmail.com> Co-authored-by: xginn8 <xginn8@users.noreply.github.com>
ocworld
pushed a commit
to AhnLab-OSS/influxdb-python
that referenced
this pull request
Apr 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the client new methods which allow create, show and drop continuous queries in InfluxDB more easily.