-
Notifications
You must be signed in to change notification settings - Fork 524
Add CQs management methods to the client #681
Conversation
The Travis build is affected by what has been described in #679 . Should I cherry-pick this commit or wait for that PR to be merged? |
You will have to take all of #679 and modify your docstrings (see failed PEP257) to pass CI. |
efb46d9
to
711508f
Compare
This PR is ready to be reviewed. |
thanks for contributing to the project @lukaszdudek-silvair, I will review this in the next few days |
i don't think in my entire github history have i come searching for a feature request or its progress in issues to find that it's been PR'd within the last couple weeks to have it potentially implemented so imminently. the ability to create retention policies without the corresponding CQs seemed like a strange choice. i too would very much enjoy this getting added as soon as time allows. thanks, @lukaszdudek-silvair for the legwork on this. looking forward to the polished version. |
Signed-off-by: Matthew McGinn <mamcgi@gmail.com>
slow clap |
@lukaszdudek-silvair thank you for contributing!! |
* Add CQs management methods to the client
* Add CQs management methods to the client
Duplicates #414 & fixes #207 .
Thanks to @smolse for providing this implementation!