Skip to content

Commit f36b816

Browse files
ethanndicksonethanndickson
authored
chore: add coder version to network telemetry events (coder#13871)
1 parent b2dab33 commit f36b816

File tree

4 files changed

+97
-86
lines changed

4 files changed

+97
-86
lines changed

‎coderd/telemetry/telemetry.go

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1174,14 +1174,11 @@ type Netcheck struct {
11741174

11751175
PreferredDERP int64 `json:"preferred_derp"`
11761176

1177-
RegionLatency map[int64]time.Duration `json:"region_latency"`
11781177
RegionV4Latency map[int64]time.Duration `json:"region_v4_latency"`
11791178
RegionV6Latency map[int64]time.Duration `json:"region_v6_latency"`
11801179

11811180
GlobalV4 NetcheckIP `json:"global_v4"`
11821181
GlobalV6 NetcheckIP `json:"global_v6"`
1183-
1184-
CaptivePortal *bool `json:"captive_portal"`
11851182
}
11861183

11871184
func protoBool(b *wrapperspb.BoolValue) *bool {
@@ -1237,6 +1234,7 @@ type NetworkEvent struct {
12371234
Status string `json:"status"` // connected, disconnected
12381235
DisconnectionReason string `json:"disconnection_reason"`
12391236
ClientType string `json:"client_type"` // cli, agent, coderd, wsproxy
1237+
ClientVersion string `json:"client_version"`
12401238
NodeIDSelf uint64 `json:"node_id_self"`
12411239
NodeIDRemote uint64 `json:"node_id_remote"`
12421240
P2PEndpoint NetworkEventP2PEndpoint `json:"p2p_endpoint"`

‎tailnet/proto/tailnet.pb.go

Lines changed: 93 additions & 83 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎tailnet/proto/tailnet.proto

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ message TelemetryEvent {
166166
Status status = 4;
167167
string disconnection_reason = 5;
168168
ClientType client_type = 6;
169+
string client_version = 19;
169170
uint64 node_id_self = 7;
170171
uint64 node_id_remote = 8;
171172
P2PEndpoint p2p_endpoint = 9;

0 commit comments

Comments
 (0)