Data.parse works different in PHP & JS when truthy

Ivanca · Ivanca · commit 4a3d081e8461 · 2014-01-03T17:11:44.000-08:00
See: http://phpjs.org/functions/strtotime/#comment-983199779 Also deleted redundant 'if' to check for text === 'now' Also added | 0 missing to avoid float point numbers.
diff --git a/functions/datetime/strtotime.js b/functions/datetime/strtotime.js
@@ -1,4 +1,6 @@
-function strtotime (text, now) {
+
+
+function strtotime(text, now) {
     // Convert string representation of date and time to a timestamp
     //
     // version: 1109.2015
@@ -34,23 +36,16 @@ function strtotime (text, now) {
         .toLowerCase();
 
     if (text === 'now') {
-        return now === null || isNaN(now) ? new Date().getTime() / 1000 | 0 : now | 0;
-    }
-    if (!isNaN(parsed = Date.parse(text))) {
-        return parsed / 1000 | 0;
-    }
-    if (text === 'now') {
-        return new Date().getTime() / 1000; // Return seconds, not milli-seconds
-    }
-    if (!isNaN(parsed = Date.parse(text))) {
-        return parsed / 1000;
+        return now === null || isNaN(now) ?
+            new Date().getTime() / 1000 | 0 :
+            now | 0;
     }
 
     match = text.match(/^(\d{2,4})-(\d{2})-(\d{2})(?:\s(\d{1,2}):(\d{2})(?::\d{2})?)?(?:\.(\d+)?)?$/);
     if (match) {
-        year = match[1] >= 0 && match[1] <= 69 ? +match[1] + 2000 : match[1];
+        year = match[1] >= 0 && match[1] <= 69 ? + match[1] + 2000 : match[1];
         return new Date(year, parseInt(match[2], 10) - 1, match[3],
-            match[4] || 0, match[5] || 0, match[6] || 0, match[7] || 0) / 1000;
+            match[4] || 0, match[5] || 0, match[6] || 0, match[7] || 0) / 1000 | 0;
     }
 
     date = now ? new Date(now * 1000) : new Date();
@@ -139,5 +134,5 @@ function strtotime (text, now) {
     //if (!match.every(process))
     //    return false;
 
-    return (date.getTime() / 1000);
+    return (date.getTime() / 1000) | 0;
 }
