bugfix for similar_text.js

eis · eis · commit 587643eaaf07 · 2013-07-18T11:21:45.000+03:00
Fixing similar_text.js based on findings on http://stackoverflow.com/questions/14136349/how-does-similar-text-work Basically, in some cases the algorithm is not implemented correctly. It shouldn't produce the same result when swapping the input words but it seems to do so.
diff --git a/functions/strings/similar_text.js b/functions/strings/similar_text.js
@@ -9,6 +9,7 @@ function similar_text (first, second, percent) {
   // *     returns 2: 0
   // *     example 3: similar_text('Hello World!', null, 1);
   // *     returns 3: 58.33
+  // *   bugfixed by: Jarkko Rantavuori based on findings in stackoverflow (http://stackoverflow.com/questions/14136349/how-does-similar-text-work)
   if (first === null || second === null || typeof first === 'undefined' || typeof second === 'undefined') {
     return 0;
   }
@@ -41,7 +42,7 @@ function similar_text (first, second, percent) {
 
   if (sum) {
     if (pos1 && pos2) {
-      sum += this.similar_text(first.substr(0, pos2), second.substr(0, pos2));
+      sum += this.similar_text(first.substr(0, pos1), second.substr(0, pos2));
     }
 
     if ((pos1 + max < firstLength) && (pos2 + max < secondLength)) {

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@ function similar_text (first, second, percent) {`
`9`	`9`	`// * returns 2: 0`
`10`	`10`	`// * example 3: similar_text('Hello World!', null, 1);`
`11`	`11`	`// * returns 3: 58.33`
	`12`	`+ // * bugfixed by: Jarkko Rantavuori based on findings in stackoverflow (http://stackoverflow.com/questions/14136349/how-does-similar-text-work)`
`12`	`13`	`if (first === null \|\| second === null \|\| typeof first === 'undefined' \|\| typeof second === 'undefined') {`
`13`	`14`	`return 0;`
`14`	`15`	`}`
`@@ -41,7 +42,7 @@ function similar_text (first, second, percent) {`
`41`	`42`
`42`	`43`	`if (sum) {`
`43`	`44`	`if (pos1 && pos2) {`
`44`		`- sum += this.similar_text(first.substr(0, pos2), second.substr(0, pos2));`
	`45`	`+ sum += this.similar_text(first.substr(0, pos1), second.substr(0, pos2));`
`45`	`46`	`}`
`46`	`47`
`47`	`48`	`if ((pos1 + max < firstLength) && (pos2 + max < secondLength)) {`