Made _compare not leak to global scope

Rafal Kukawski · Rafal Kukawski · commit adc9bff30b60 · 2015-01-12T09:42:20.000+01:00
diff --git a/functions/math/min.js b/functions/math/min.js
@@ -32,7 +32,7 @@ function min() {
         }
       }
       return ar;
-    }; //function _obj2Array
+    }, //function _obj2Array
   _compare = function (current, next) {
     var i = 0,
       n = 0,
@@ -83,6 +83,7 @@ function min() {
     }
     return (next > current ? 1 : -1);
   }; //function _compare
+
   if (argc === 0) {
     throw new Error('At least one value should be passed to min()');
   } else if (argc === 1) {
@@ -91,6 +92,7 @@ function min() {
     } else {
       throw new Error('Wrong parameter count for min()');
     }
+
     if (ar.length === 0) {
       throw new Error('Array must contain at least one element for min()');
     }
@@ -99,6 +101,7 @@ function min() {
   }
 
   retVal = ar[0];
+
   for (i = 1, n = ar.length; i < n; ++i) {
     if (_compare(retVal, ar[i]) == -1) {
       retVal = ar[i];

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ function min() {`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`	`return ar;`
`35`		`- }; //function _obj2Array`
	`35`	`+ }, //function _obj2Array`
`36`	`36`	`_compare = function (current, next) {`
`37`	`37`	`var i = 0,`
`38`	`38`	`n = 0,`
`@@ -83,6 +83,7 @@ function min() {`
`83`	`83`	`}`
`84`	`84`	`return (next > current ? 1 : -1);`
`85`	`85`	`}; //function _compare`
	`86`	`+`
`86`	`87`	`if (argc === 0) {`
`87`	`88`	`throw new Error('At least one value should be passed to min()');`
`88`	`89`	`} else if (argc === 1) {`
`@@ -91,6 +92,7 @@ function min() {`
`91`	`92`	`} else {`
`92`	`93`	`throw new Error('Wrong parameter count for min()');`
`93`	`94`	`}`
	`95`	`+`
`94`	`96`	`if (ar.length === 0) {`
`95`	`97`	`throw new Error('Array must contain at least one element for min()');`
`96`	`98`	`}`
`@@ -99,6 +101,7 @@ function min() {`
`99`	`101`	`}`
`100`	`102`
`101`	`103`	`retVal = ar[0];`
	`104`	`+`
`102`	`105`	`for (i = 1, n = ar.length; i < n; ++i) {`
`103`	`106`	`if (_compare(retVal, ar[i]) == -1) {`
`104`	`107`	`retVal = ar[i];`