refactor error handling

theandrewykim · theandrewykim · commit a12d7c92f3bc · 2020-09-30T15:13:15.000-05:00
diff --git a/lib/intercom/request.rb b/lib/intercom/request.rb
@@ -158,13 +158,7 @@ def execute(target_base_url = nil, token:, read_timeout: 90, open_timeout: 30, a
     private def raise_errors_on_failure(res)
       code = res.code.to_i
 
-      if code == 404
-        raise Intercom::ResourceNotFound, 'Resource Not Found'
-      elsif code == 401
-        raise Intercom::AuthenticationError, 'Unauthorized'
-      elsif code == 403
-        raise Intercom::AuthenticationError, 'Forbidden'
-      elsif code == 429
+      if code ==429
         raise Intercom::RateLimitExceeded, 'Rate Limit Exceeded'
       elsif code == 500
         raise Intercom::ServerError, 'Server Error'
