explicitly fail if someone attempts to use count with block (as supported by Enumerable) on UserCollectionProxy

darragh · darragh · commit f1778306fdce · 2012-11-30T13:55:37.000Z
diff --git a/lib/intercom/user_collection_proxy.rb b/lib/intercom/user_collection_proxy.rb
@@ -17,8 +17,11 @@ module Intercom
   #    end
   #
   class UserCollectionProxy
+    include Enumerable
+
     # @return [Integer] number of users tracked on Intercom for this application
     def count
+      raise ArgumentError.new("count doesn't support block argument") if block_given?
       response = Intercom.get("users", {:per_page => 1})
       response["total_count"]
     end
@@ -37,7 +40,5 @@ def each(&block)
         fetch_another_page = !current_page["next_page"].nil?
       end
     end
-
-    include Enumerable
   end
 end
diff --git a/spec/unit/intercom/user_collection_proxy_spec.rb b/spec/unit/intercom/user_collection_proxy_spec.rb
@@ -25,6 +25,12 @@
     Intercom::User.all.count.must_equal 3
   end
 
+  it "explicitly doesn't support block argument for count" do
+    assert_raises ArgumentError do
+      Intercom::User.all.count {|_| true }
+    end
+  end
+
   it "loads multiple pages" do
     Intercom.expects(:get).with("users", {:page => 1}).returns(page_of_users(1, 1))
     Intercom.expects(:get).with("users", {:page => 2}).returns(page_of_users(2, 1))
