From 51ad11679583f39fe0ebbf65317e625a70660aee Mon Sep 17 00:00:00 2001 From: Gabriel Anca Date: Wed, 13 Nov 2019 14:36:43 +0000 Subject: [PATCH] Accept 'Unstable' API Version --- lib/intercom/client.rb | 2 +- spec/unit/intercom/client_spec.rb | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/intercom/client.rb b/lib/intercom/client.rb index a7586798..01a576f2 100644 --- a/lib/intercom/client.rb +++ b/lib/intercom/client.rb @@ -136,7 +136,7 @@ def validate_credentials! def validate_api_version! error = MisconfiguredClientError.new("api_version must be either nil or a valid API version") - fail error if (@api_version && Gem::Version.new(@api_version) < Gem::Version.new('1.0')) + fail error if (@api_version && @api_version != 'Unstable' && Gem::Version.new(@api_version) < Gem::Version.new('1.0')) end def execute_request(request) diff --git a/spec/unit/intercom/client_spec.rb b/spec/unit/intercom/client_spec.rb index 2eec321e..47fe6416 100644 --- a/spec/unit/intercom/client_spec.rb +++ b/spec/unit/intercom/client_spec.rb @@ -66,6 +66,10 @@ module Intercom assert_nil(Client.new(app_id: app_id, api_key: api_key, api_version: nil).api_version) end + it 'allows api version to be Unstable' do + Client.new(app_id: app_id, api_key: api_key, api_version: 'Unstable').api_version.must_equal('Unstable') + end + it 'raises on invalid api version' do proc { Client.new(app_id: app_id, api_key: api_key, api_version: '0.2') }.must_raise MisconfiguredClientError end