Adding support for None FlatStore values.

jkeyes · jkeyes · commit 8ca7d74b7758 · 2015-05-12T12:04:04.000+01:00
diff --git a/intercom/lib/flat_store.py b/intercom/lib/flat_store.py
@@ -12,10 +12,11 @@ def __init__(self, *args, **kwargs):
     def __setitem__(self, key, value):
         if not (
             isinstance(value, numbers.Real) or
-            isinstance(value, six.string_types)
+            isinstance(value, six.string_types) or
+            value is None
         ):
             raise ValueError(
-                "custom data only allows string and real number values")
+                "custom data only allows None, string and real number values")
         if not isinstance(key, six.string_types):
             raise ValueError("custom data only allows string keys")
         super(FlatStore, self).__setitem__(key, value)
diff --git a/tests/unit/lib/test_flat_store.py b/tests/unit/lib/test_flat_store.py
@@ -35,3 +35,9 @@ def it_sets_and_merges_valid_entries(self):
         data = FlatStore(a=1, b=2)
         eq_(data["a"], 1)
         eq_(data["b"], 2)
+
+    @istest
+    def it_sets_null_entries(self):
+        data = FlatStore()
+        data["a"] = None
+        eq_(data["a"], None)
