Skip to content

Commit 6eaa712

Browse files
minor refactoring
1 parent fecf8e8 commit 6eaa712

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

2024/ruby/lib/advent_05_print_queue.rb

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,24 +104,15 @@ def lower_priority_pages_for(number)
104104
end
105105

106106
def in_order?
107-
numbers = page_update.numbers
108-
109-
numbers.each_with_index do |number, i|
110-
rest = numbers[i + 1..]
111-
return false unless lower_priority_pages_for(number).all? { |n| rest.include?(n) }
112-
end
113-
114-
true
107+
pairs = page_update.numbers.each_cons(2)
108+
pairs.all? { |a, b| lower_priority_pages_for(a).include?(b) }
115109
end
116110

117111
def reorder
118112
numbers = page_update.numbers.to_a
119-
120113
return [] if numbers.empty?
121114

122-
numbers.sort! do |a, b|
123-
lower_priority_pages_for(a).include?(b) ? -1 : 1
124-
end
115+
numbers.sort! { |a, b| lower_priority_pages_for(a).include?(b) ? -1 : 1 }
125116

126117
PageUpdate.new(numbers)
127118
end

0 commit comments

Comments
 (0)