impi_fru.c with multi change to 0xFF #334

howardliu1223 · 2022-03-15T10:43:08Z

Dear Sir,

There is a problem in ipmi_fru.c.

Line 5081~Line5084
if ((f_type == 'c' ) || (f_type == 'b' ) || (f_type == 'p' )) {
printf("Change multi offset from %d to %d\n", header.offset.multi, header.offset.multi + change_size_by_8);
header.offset.multi += change_size_by_8;
}

if header.offset.multi = 0 and chagne_size_by_8 = -1, header.offset.multi will be 0xff.
Check 0, no change?

Thanks.

AlexanderAmelkin · 2022-04-22T13:43:55Z

The problem is actually much deeper. The code assumes that there is a specific order of sections, which is not necessarily true.
The code must be substantially refactored to account for arbitrary order of sections. It's not just checking for 0. The same issue exists above for board and product areas.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

impi_fru.c with multi change to 0xFF #334

impi_fru.c with multi change to 0xFF #334

howardliu1223 commented Mar 15, 2022

AlexanderAmelkin commented Apr 22, 2022

impi_fru.c with multi change to 0xFF #334

impi_fru.c with multi change to 0xFF #334

Comments

howardliu1223 commented Mar 15, 2022

Line 5081~Line5084 if ((f_type == 'c' ) || (f_type == 'b' ) || (f_type == 'p' )) { printf("Change multi offset from %d to %d\n", header.offset.multi, header.offset.multi + change_size_by_8); header.offset.multi += change_size_by_8; }

AlexanderAmelkin commented Apr 22, 2022

Line 5081~Line5084
if ((f_type == 'c' ) || (f_type == 'b' ) || (f_type == 'p' )) {
printf("Change multi offset from %d to %d\n", header.offset.multi, header.offset.multi + change_size_by_8);
header.offset.multi += change_size_by_8;
}