Skip to content

chore(push): improve schema design of PushResult #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 9, 2020
Merged

chore(push): improve schema design of PushResult #1036

merged 3 commits into from
Feb 9, 2020

Conversation

billiegoose
Copy link
Member

@billiegoose billiegoose commented Feb 9, 2020 •
edited
Loading

BREAKING CHANGE: the push function now throws if any of the refs on the remote were not updated successfully. It also returns a nicely typed result object organized by ref, rather than a loose collection of strings organized by outcome.

Bonus: the entire __tests__ folder now type-checks! And will continue to do so because I added it to the linting step.

@isomorphic-git-bot
Copy link

Thank you wmhilton! I auto-formatted the code using prettier-standard. 🤖

@karma-pr-reporter
Copy link

Test Results for 96d893e:

Browser Pass Skip Fail Time Disconnect?
Chrome 79.0.3945 (Windows 10 0.0.0) 360 1 0 3m:17s false
Chrome Mobile 78.0.3904 (Android 0.0.0) 360 1 0 1m:48s false
Firefox 72.0.0 (Ubuntu 0.0.0) 360 1 0 1m:24s false
HeadlessChrome 0.0.0 (Linux 0.0.0) 360 1 0 0m:48s false
Mobile Safari 13.0.0 (iOS 13.0.0) 360 1 0 2m:40s false
Safari 13.0.3 (Mac OS X 10.15.1) 360 1 0 3m:5s false

Longest running tests

  • 12.002 secs - fetch shallow fetch relative (from Github) - Firefox
  • 10.26 secs - fetch shallow fetch (from Github) - Firefox
  • 9.875 secs - GitPackIndex to .idx file from .pack - Firefox
  • 9.153 secs - GitPackIndex from .pack - Firefox
  • 8.226 secs - fetch fetch (from Github) - Firefox
  • 8.137 secs - fetch shallow fetch (from Github) - HeadlessChrome
  • 7.842 secs - fetch fetch (from Github) - HeadlessChrome
  • 7.52 secs - fetch shallow fetch (from Github) - Chrome Mobile
  • 7.429 secs - fetch shallow fetch relative (from Github) - Chrome
  • 7.279 secs - fetch shallow fetch (from Github) - Chrome
  • 7.057 secs - fetch fetch --prune-tags from git-http-mock-server - Safari

@billiegoose billiegoose merged commit 08ce40e into beta Feb 9, 2020
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.0.0-beta.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

@billiegoose billiegoose deleted the chore/beta-typed-push branch February 10, 2020 00:15
@isomorphic-git-bot
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

modesty pushed a commit to modesty/isomorphic-git that referenced this pull request Apr 9, 2024
@billiegoose
chore(push): improve schema design of PushResult (isomorphic-git#1036)
e14cd49 
BREAKING CHANGE: the `push` function now throws if any of the refs on the remote were not updated successfully. It also returns a nicely typed result object organized by ref, rather than a loose collection of strings organized by outcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@billiegoose @karma-pr-reporter @isomorphic-git-bot