06.03 simplify new Tag views with generics

jambonrose · jambonrose · commit 01d40386eca8 · 2019-01-12T09:39:12.000-05:00
diff --git a/src/organizer/views.py b/src/organizer/views.py
@@ -1,12 +1,12 @@
 """Views for Organizer App"""
-from django.shortcuts import (
-    get_object_or_404,
-    redirect,
-    render,
+from django.urls import reverse_lazy
+from django.views.generic import (
+    CreateView,
+    DeleteView,
+    DetailView,
+    ListView,
+    UpdateView,
 )
-from django.urls import reverse
-from django.views import View
-from django.views.generic import DetailView, ListView
 
 from .forms import TagForm
 from .models import Startup, Tag
@@ -26,69 +26,30 @@ class TagDetail(DetailView):
     template_name = "tag/detail.html"
 
 
-class TagCreate(View):
+class TagCreate(CreateView):
     """Create new Tags via HTML form"""
 
-    def get(self, request):
-        """Display an HTML form"""
-        context = {"form": TagForm(), "update": False}
-        return render(request, "tag/form.html", context)
+    form_class = TagForm
+    model = Tag
+    template_name = "tag/form.html"
+    extra_context = {"update": False}
 
-    def post(self, request):
-        """Handle Form submission: save Tag"""
-        tform = TagForm(request.POST)
-        if tform.is_valid():
-            tag = tform.save()
-            return redirect(tag.get_absolute_url())
-        # invalid data; show form with errors
-        context = {"form": tform, "update": False}
-        return render(request, "tag/form.html", context)
 
-
-class TagUpdate(View):
+class TagUpdate(UpdateView):
     """Update a Tag via HTML form"""
 
-    def get(self, request, slug):
-        """Display an HTML form with pre-filled data"""
-        tag = get_object_or_404(Tag, slug=slug)
-        context = {
-            "tag": tag,
-            "form": TagForm(instance=tag),
-            "update": True,
-        }
-        return render(request, "tag/form.html", context)
-
-    def post(self, request, slug):
-        """Handle Form submission: save Tag"""
-        tag = get_object_or_404(Tag, slug=slug)
-        tform = TagForm(request.POST, instance=tag)
-        if tform.is_valid():
-            tag = tform.save()
-            return redirect(tag.get_absolute_url())
-        # invalid data; show form with errors
-        context = {
-            "tag": tag,
-            "form": tform,
-            "update": True,
-        }
-        return render(request, "tag/form.html", context)
-
-
-class TagDelete(View):
+    form_class = TagForm
+    model = Tag
+    template_name = "tag/form.html"
+    extra_context = {"update": True}
+
+
+class TagDelete(DeleteView):
     """Confirm and delete a Tag via HTML Form"""
 
-    def get(self, request, slug):
-        """Display an HTML form to confirm removal"""
-        tag = get_object_or_404(Tag, slug=slug)
-        return render(
-            request, "tag/confirm_delete.html", {"tag": tag}
-        )
-
-    def post(self, request, slug):
-        """Delete Tag"""
-        tag = get_object_or_404(Tag, slug=slug)
-        tag.delete()
-        return redirect(reverse("tag_list"))
+    model = Tag
+    template_name = "tag/confirm_delete.html"
+    success_url = reverse_lazy("tag_list")
 
 
 class StartupList(ListView):
