Skip to content

Fix mapping for empty collection value on an array property #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

Fix mapping for empty collection value on an array property #426

merged 1 commit into from
Oct 7, 2020

Conversation

Korbeil
Copy link
Member

@Korbeil Korbeil commented Oct 6, 2020 •
edited
Loading

Fix #425

When an array has no description about its collection value type, it was not considered as transformable by the AutoMapper.
This is because of symfony/symfony#38041, I fixed it in symfony/symfony#38446, so we just have to flag symfony/property-info v5.1.6 & v5.1.7 as conflict with us.

@Korbeil Korbeil self-assigned this Oct 6, 2020
@Korbeil Korbeil merged commit 1e521c3 into janephp:6.2.x Oct 7, 2020
@Korbeil Korbeil deleted the fix/issue-425 branch October 7, 2020 08:40
@Korbeil Korbeil mentioned this pull request Oct 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odolbeau odolbeau odolbeau approved these changes

Assignees

@Korbeil Korbeil

Labels
review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Korbeil @odolbeau