fix: Do not write 2 errors to api on template fetch error (coder#2285)

Emyrk · web-flow · commit 49f857806fb9 · 2022-06-13T15:42:14.000Z
diff --git a/coderd/httpmw/templateparam.go b/coderd/httpmw/templateparam.go
@@ -37,6 +37,7 @@ func ExtractTemplateParam(db database.Store) func(http.Handler) http.Handler {
 				httpapi.Write(rw, http.StatusNotFound, httpapi.Response{
 					Message: fmt.Sprintf("Template %q does not exist.", templateID),
 				})
+				return
 			}
 			if err != nil {
 				httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,7 @@ func ExtractTemplateParam(db database.Store) func(http.Handler) http.Handler {`
`37`	`37`	`httpapi.Write(rw, http.StatusNotFound, httpapi.Response{`
`38`	`38`	`Message: fmt.Sprintf("Template %q does not exist.", templateID),`
`39`	`39`	`})`
	`40`	`+ return`
`40`	`41`	`}`
`41`	`42`	`if err != nil {`
`42`	`43`	`httpapi.Write(rw, http.StatusInternalServerError, httpapi.Response{`