fix($compile): detect <a> elements inside <svg>

gkalpak · gkalpak · commit 2687c2614058 · 2016-07-20T23:17:37.000+03:00
diff --git a/src/ng/compile.js b/src/ng/compile.js
@@ -765,7 +765,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {
           }
         }
 
-        nodeName = nodeName_(this.$$element);
+        // SVG elements' `nodeName` can be lowercase
+        nodeName = nodeName_(this.$$element).toUpperCase();
 
         // sanitize a[href] and img[src] values
         if ((nodeName === 'A' && (key === 'href' || key === 'xlinkHref')) ||
diff --git a/test/ng/compileSpec.js b/test/ng/compileSpec.js
@@ -4804,6 +4804,8 @@ describe('$compile', function() {
     });
 
     it('should use $$sanitizeUri when working with svg and xlink:href', function() {
+      if (!window.SVGElement) return;
+
       var $$sanitizeUri = jasmine.createSpy('$$sanitizeUri');
       module(function($provide) {
         $provide.value('$$sanitizeUri', $$sanitizeUri);

Original file line number	Diff line number	Diff line change
`@@ -765,7 +765,8 @@ function $CompileProvider($provide, $$sanitizeUriProvider) {`
`765`	`765`	`}`
`766`	`766`	`}`
`767`	`767`
`768`		`- nodeName = nodeName_(this.$$element);`
	`768`	+ // SVG elements' `nodeName` can be lowercase
	`769`	`+ nodeName = nodeName_(this.$$element).toUpperCase();`
`769`	`770`
`770`	`771`	`// sanitize a[href] and img[src] values`
`771`	`772`	`if ((nodeName === 'A' && (key === 'href' \|\| key === 'xlinkHref')) \|\|`