Updated recylerview example

vogella · vogella · commit 1415ec81b11b · 2015-11-24T08:57:59.000+01:00
diff --git a/com.vogella.android.recyclerview/src/com/vogella/android/recyclerview/MainActivity.java b/com.vogella.android.recyclerview/src/com/vogella/android/recyclerview/MainActivity.java
@@ -31,14 +31,13 @@ protected void onCreate(Bundle savedInstanceState) {
 		//	RecyclerView.ItemDecoration itemDecoration = new DividerItemDecoration(this, DividerItemDecoration.VERTICAL_LIST);
 		//	recyclerView.addItemDecoration(itemDecoration);
 
-		ArrayList<String> input = new ArrayList<String>();
+		ArrayList<String> values = new ArrayList<String>();
 		for (int i = 0; i < 100; i++) {
-			input.add("Test" + i);
+			values.add("Test" + i);
 		}
 
 		// specify an adapter (see also next example)
-		mAdapter = new MyAdapter(input);
+		mAdapter = new MyAdapter(values);
 		recyclerView.setAdapter(mAdapter);
-		mAdapter.remove("Test1");
 	}
 }
diff --git a/com.vogella.android.recyclerview/src/com/vogella/android/recyclerview/MyAdapter.java b/com.vogella.android.recyclerview/src/com/vogella/android/recyclerview/MyAdapter.java
@@ -10,7 +10,7 @@
 import android.widget.TextView;
 
 public class MyAdapter extends RecyclerView.Adapter<MyAdapter.ViewHolder> {
-	private ArrayList<String> mDataset;
+	private ArrayList<String> values;
 
 	// Provide a reference to the views for each data item
 	// Complex data items may need more than one view per item, and
@@ -19,63 +19,66 @@ public class ViewHolder extends RecyclerView.ViewHolder {
 		// each data item is just a string in this case
 		public TextView txtHeader;
 		public TextView txtFooter;
+		public View layout;
 
 		public ViewHolder(View v) {
 			super(v);
+			layout = v;
 			txtHeader = (TextView) v.findViewById(R.id.firstLine);
 			txtFooter = (TextView) v.findViewById(R.id.secondLine);
 		}
 	}
 
 	public void add(int position, String item) {
-		mDataset.add(position, item);
+		values.add(position, item);
 		notifyItemInserted(position);
 	}
 
-	public void remove(String item) {
-		int position = mDataset.indexOf(item);
-		mDataset.remove(position);
+	public void remove(int position) {
+		values.remove(position);
 		notifyItemRemoved(position);
 	}
 
 	// Provide a suitable constructor (depends on the kind of dataset)
 	public MyAdapter(ArrayList<String> myDataset) {
-		mDataset = myDataset;
+		values = myDataset;
 	}
 
 	// Create new views (invoked by the layout manager)
 	@Override
 	public MyAdapter.ViewHolder onCreateViewHolder(ViewGroup parent,
 			int viewType) {
 		// create a new view
-		View v = LayoutInflater.from(parent.getContext()).inflate(R.layout.rowlayout, parent, false);
+		LayoutInflater inflater = LayoutInflater.from(
+				parent.getContext());
+		View v = 
+				inflater.inflate(R.layout.rowlayout, parent, false);
 		// set the view's size, margins, paddings and layout parameters
 		ViewHolder vh = new ViewHolder(v);
 		return vh;
 	}
 
 	// Replace the contents of a view (invoked by the layout manager)
 	@Override
-	public void onBindViewHolder(ViewHolder holder, int position) {
+	public void onBindViewHolder(ViewHolder holder, final int position) {
 		// - get element from your dataset at this position
 		// - replace the contents of the view with that element
-		final String name = mDataset.get(position);
-		holder.txtHeader.setText(mDataset.get(position));
+		final String name = values.get(position);
+		holder.txtHeader.setText(name);
 		holder.txtHeader.setOnClickListener(new OnClickListener() {
 		        @Override
 		        public void onClick(View v) {
-		        	remove(name);
+		        	remove(position);
 		        }
 		    });
 		
-		holder.txtFooter.setText("Footer: " + mDataset.get(position));
-
+		holder.txtFooter.setText("Footer: " + name);
 	}
 
 	// Return the size of your dataset (invoked by the layout manager)
 	@Override
 	public int getItemCount() {
-		return mDataset.size();
+		return values.size();
 	}
 
 }

Original file line number	Diff line number	Diff line change
`@@ -31,14 +31,13 @@ protected void onCreate(Bundle savedInstanceState) {`
`31`	`31`	`// RecyclerView.ItemDecoration itemDecoration = new DividerItemDecoration(this, DividerItemDecoration.VERTICAL_LIST);`
`32`	`32`	`// recyclerView.addItemDecoration(itemDecoration);`
`33`	`33`
`34`		`- ArrayList<String> input = new ArrayList<String>();`
	`34`	`+ ArrayList<String> values = new ArrayList<String>();`
`35`	`35`	`for (int i = 0; i < 100; i++) {`
`36`		`- input.add("Test" + i);`
	`36`	`+ values.add("Test" + i);`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`// specify an adapter (see also next example)`
`40`		`- mAdapter = new MyAdapter(input);`
	`40`	`+ mAdapter = new MyAdapter(values);`
`41`	`41`	`recyclerView.setAdapter(mAdapter);`
`42`		`- mAdapter.remove("Test1");`
`43`	`42`	`}`
`44`	`43`	`}`