refactor(renderer): stop setting templateParents to ProxyViewContainers

sis0k0 · sis0k0 · commit eb86d3e16a97 · 2017-08-16T19:47:31.000+03:00
diff --git a/nativescript-angular/renderer.ts b/nativescript-angular/renderer.ts
@@ -23,7 +23,6 @@ export const HOST_ATTR = `_nghost-${COMPONENT_VARIABLE}`;
 export const CONTENT_ATTR = `_ngcontent-${COMPONENT_VARIABLE}`;
 const ATTR_SANITIZER = /-/g;
 
-
 @Injectable()
 export class NativeScriptRendererFactory implements RendererFactory2 {
     private componentRenderers = new Map<string, NativeScriptRenderer>();
diff --git a/nativescript-angular/view-util.ts b/nativescript-angular/view-util.ts
@@ -65,9 +65,11 @@ export class ViewUtil {
 
         this.addToQueue(parent, child, previous, next);
 
-        if (isDetachedElement(child)) {
+        if (child instanceof InvisibleNode) {
             child.templateParent = parent;
-        } else {
+        }
+
+        if (!isDetachedElement(child)) {
             this.addToVisualTree(parent, child, next);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -65,9 +65,11 @@ export class ViewUtil {`
`65`	`65`
`66`	`66`	`this.addToQueue(parent, child, previous, next);`
`67`	`67`
`68`		`- if (isDetachedElement(child)) {`
	`68`	`+ if (child instanceof InvisibleNode) {`
`69`	`69`	`child.templateParent = parent;`
`70`		`- } else {`
	`70`	`+ }`
	`71`	`+`
	`72`	`+ if (!isDetachedElement(child)) {`
`71`	`73`	`this.addToVisualTree(parent, child, next);`
`72`	`74`	`}`
`73`	`75`	`}`