Skip to content

Commit 0bf1b01

Browse files
fix(site): remove extra spacing on template variables page
1 parent 56889d6 commit 0bf1b01

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

site/src/pages/TemplateSettingsPage/TemplateVariablesPage/TemplateVariablesPageView.tsx

+12-10
Original file line numberDiff line numberDiff line change
@@ -44,21 +44,23 @@ export const TemplateVariablesPageView: FC<TemplateVariablesPageViewProps> = ({
4444
!errors.getTemplateDataError &&
4545
!errors.updateTemplateError
4646
const { t } = useTranslation("templateVariablesPage")
47-
47+
const hasError = Object.values(errors).some((error) => Boolean(error))
4848
return (
4949
<>
5050
<PageHeader className={classes.pageHeader}>
5151
<PageHeaderTitle>{t("title")}</PageHeaderTitle>
5252
</PageHeader>
53-
<div className={classes.errorContainer}>
54-
{Boolean(errors.getTemplateDataError) && (
55-
<ErrorAlert error={errors.getTemplateDataError} />
56-
)}
57-
{Boolean(errors.updateTemplateError) && (
58-
<ErrorAlert error={errors.updateTemplateError} />
59-
)}
60-
{Boolean(errors.jobError) && <ErrorAlert error={errors.jobError} />}
61-
</div>
53+
{hasError && (
54+
<div className={classes.errorContainer}>
55+
{Boolean(errors.getTemplateDataError) && (
56+
<ErrorAlert error={errors.getTemplateDataError} />
57+
)}
58+
{Boolean(errors.updateTemplateError) && (
59+
<ErrorAlert error={errors.updateTemplateError} />
60+
)}
61+
{Boolean(errors.jobError) && <ErrorAlert error={errors.jobError} />}
62+
</div>
63+
)}
6264
{isLoading && <Loader />}
6365
{templateVersion && templateVariables && templateVariables.length > 0 && (
6466
<TemplateVariablesForm

0 commit comments

Comments
 (0)