fix(cli): correctly print deprecated warnings (coder#8771)

ammario · web-flow · commit edd9628aa604 · 2023-07-27T16:42:18.000Z
In the previous implementation, it was possible for default-set values
to trigger the deprecation warning.
diff --git a/cli/server.go b/cli/server.go
@@ -1148,7 +1148,7 @@ func PrintDeprecatedOptions() clibase.MiddlewareFunc {
 					continue
 				}
 
-				if opt.Value.String() == opt.Default {
+				if opt.ValueSource == clibase.ValueSourceNone || opt.ValueSource == clibase.ValueSourceDefault {
 					continue
 				}
 

Original file line number	Diff line number	Diff line change
`@@ -1148,7 +1148,7 @@ func PrintDeprecatedOptions() clibase.MiddlewareFunc {`
`1148`	`1148`	`continue`
`1149`	`1149`	`}`
`1150`	`1150`
`1151`		`- if opt.Value.String() == opt.Default {`
	`1151`	`+ if opt.ValueSource == clibase.ValueSourceNone \|\| opt.ValueSource == clibase.ValueSourceDefault {`
`1152`	`1152`	`continue`
`1153`	`1153`	`}`
`1154`	`1154`