Convert tests to com.sun.net.httpserver
#293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Mar 26, 2025
| String state = req.getParameter("state"); | ||
| resp.sendRedirect(jenkinsRule.getURL() + "securityRealm/finishLogin?code=" + code + "&state=" + state); | ||
| Fields fields = new Fields(); | ||
| UrlEncoded.decodeUtf8To(he.getRequestURI().getQuery(), fields); |
There was a problem hiding this comment.
Could use some copypasta like this instead to completely avoid Jetty here, but this seems more maintainable and I doubt this method will change in the future (it is not tied to EE version). No strong preference here.
6 tasks
MarkEWaite
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like jenkinsci/kubernetes-credentials-plugin#54. Makes these tests less fragile by eliminating reliance on a particular EE version (currently EE 9) in favor of more generic Java Platform functionality.
Testing done
mvn clean verify