[Form] Simplified a bit FormUtil and extended test coverage

stloyd · stloyd · commit 18a83c67f41c · 2011-10-07T12:04:26.000+02:00
diff --git a/src/Symfony/Component/Form/Util/FormUtil.php b/src/Symfony/Component/Form/Util/FormUtil.php
@@ -15,11 +15,7 @@ abstract class FormUtil
 {
     static public function toArrayKey($value)
     {
-        if ((string) (int) $value === (string) $value) {
-            return (int) $value;
-        }
-
-        if (is_bool($value)) {
+        if (is_bool($value) || (string) (int) $value === (string) $value) {
             return (int) $value;
         }
 
@@ -52,7 +48,7 @@ static public function isChoiceGroup($choice)
      */
     static public function isChoiceSelected($choice, $value)
     {
-        $choice = FormUtil::toArrayKey($choice);
+        $choice = static::toArrayKey($choice);
 
         // The value should already have been converted by value transformers,
         // otherwise we had to do the conversion on every call of this method
diff --git a/tests/Symfony/Tests/Component/Form/Util/FormUtilTest.php b/tests/Symfony/Tests/Component/Form/Util/FormUtilTest.php
@@ -50,4 +50,56 @@ public function testToArrayKeys()
 
         $this->assertSame($out, FormUtil::toArrayKeys($in));
     }
+
+    public function isChoiceGroupProvider()
+    {
+        return array(
+            array(false, 0),
+            array(false, '0'),
+            array(false, '1'),
+            array(false, 1),
+            array(false, ''),
+            array(false, null),
+            array(false, true),
+
+            array(true, array()),
+            array(true, new \SplFixedArray(1)),
+        );
+    }
+
+    /**
+     * @dataProvider isChoiceGroupProvider
+     */
+    public function testIsChoiceGroup($expected, $value)
+    {
+        $this->assertSame($expected, FormUtil::isChoiceGroup($value));
+    }
+
+    public function isChoiceSelectedProvider()
+    {
+        return array(
+            array(true, 0, 0),
+            array(true, '0', 0),
+            array(true, '1', 1),
+            array(true, false, 0),
+            array(true, true, 1),
+            array(true, '', ''),
+            array(true, null, ''),
+            array(true, '1.23', '1.23'),
+            array(true, 'foo', 'foo'),
+            array(true, 'foo10', 'foo10'),
+            array(true, 'foo', array(1, 'foo', 'foo10')),
+
+            array(false, 10, array(1, 'foo', 'foo10')),
+            array(false, 0, array(1, 'foo', 'foo10')),
+        );
+    }
+
+    /**
+     * @dataProvider isChoiceSelectedProvider
+     */
+    public function testIsChoiceSelected($expected, $choice, $value)
+    {
+        $this->assertSame($expected, FormUtil::isChoiceSelected($choice, $value));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,7 @@ abstract class FormUtil`
`15`	`15`	`{`
`16`	`16`	`static public function toArrayKey($value)`
`17`	`17`	`{`
`18`		`- if ((string) (int) $value === (string) $value) {`
`19`		`- return (int) $value;`
`20`		`- }`
`21`		`-`
`22`		`- if (is_bool($value)) {`
	`18`	`+ if (is_bool($value) \|\| (string) (int) $value === (string) $value) {`
`23`	`19`	`return (int) $value;`
`24`	`20`	`}`
`25`	`21`
`@@ -52,7 +48,7 @@ static public function isChoiceGroup($choice)`
`52`	`48`	`*/`
`53`	`49`	`static public function isChoiceSelected($choice, $value)`
`54`	`50`	`{`
`55`		`- $choice = FormUtil::toArrayKey($choice);`
	`51`	`+ $choice = static::toArrayKey($choice);`
`56`	`52`
`57`	`53`	`// The value should already have been converted by value transformers,`
`58`	`54`	`// otherwise we had to do the conversion on every call of this method`