Skip to content

Commit 5d5d7d4

Browse files
Decreasing code complexity of meets_required_version?
1 parent 74896f6 commit 5d5d7d4

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

lib/git/lib.rb

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -676,17 +676,11 @@ def current_command_version
676676
end
677677

678678
def required_command_version
679-
[1, 6, 0, 0]
679+
[1, 6]
680680
end
681681

682682
def meets_required_version?
683-
current_version = self.current_command_version
684-
required_version = self.required_command_version
685-
686-
return current_version[0] >= required_version[0] &&
687-
current_version[1] >= required_version[1] &&
688-
(current_version[2] ? current_version[2] >= required_version[2] : true) &&
689-
(current_version[3] ? current_version[3] >= required_version[3] : true)
683+
(self.current_command_version <=> self.required_command_version) >= 0
690684
end
691685

692686

0 commit comments

Comments
 (0)