Optimize sections a bit to re-use the child renderer.

joshthecoder · joshthecoder · commit 78277ef62d0d · 2010-03-19T17:15:39.000-05:00
This should reduce any allocation overhead hopefully.
diff --git a/mustang/Node.ooc b/mustang/Node.ooc
@@ -7,6 +7,14 @@ import mustang/[Context, Value, Renderer, Template, Escape]
 */
 TNode: abstract class {
     next, firstChild: This
+    childrenRenderer: Renderer
+
+    renderChildren: func(context: Context, out: Writer) {
+        if(!childrenRenderer) {
+            childrenRenderer = Renderer new(firstChild)
+        }
+        childrenRenderer render(context, out)
+    }
 
     render: abstract func(context: Context, out: Writer)
 
@@ -78,12 +86,12 @@ SectionNode: class extends TNode {
                     itemContext setValue("item", item)
                 }
 
-                Renderer new(this firstChild) render(itemContext, out)
+                renderChildren(itemContext, out)
             }
         }
         else if(variable instanceOf(BoolValue)) {
             if((variable as BoolValue) isTrue()) {
-                Renderer new(this firstChild) render(context, out)
+                renderChildren(context, out)
             }
         }
         else {

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,14 @@ import mustang/[Context, Value, Renderer, Template, Escape]`
`7`	`7`	`*/`
`8`	`8`	`TNode: abstract class {`
`9`	`9`	`next, firstChild: This`
	`10`	`+ childrenRenderer: Renderer`
	`11`	`+`
	`12`	`+ renderChildren: func(context: Context, out: Writer) {`
	`13`	`+ if(!childrenRenderer) {`
	`14`	`+ childrenRenderer = Renderer new(firstChild)`
	`15`	`+ }`
	`16`	`+ childrenRenderer render(context, out)`
	`17`	`+ }`
`10`	`18`
`11`	`19`	`render: abstract func(context: Context, out: Writer)`
`12`	`20`
`@@ -78,12 +86,12 @@ SectionNode: class extends TNode {`
`78`	`86`	`itemContext setValue("item", item)`
`79`	`87`	`}`
`80`	`88`
`81`		`- Renderer new(this firstChild) render(itemContext, out)`
	`89`	`+ renderChildren(itemContext, out)`
`82`	`90`	`}`
`83`	`91`	`}`
`84`	`92`	`else if(variable instanceOf(BoolValue)) {`
`85`	`93`	`if((variable as BoolValue) isTrue()) {`
`86`		`- Renderer new(this firstChild) render(context, out)`
	`94`	`+ renderChildren(context, out)`
`87`	`95`	`}`
`88`	`96`	`}`
`89`	`97`	`else {`