Skip to content

bug: infinite loop/memory leak #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yevgenypats opened this issue Oct 20, 2019 · 4 comments
Closed

bug: infinite loop/memory leak #53

yevgenypats opened this issue Oct 20, 2019 · 4 comments

Comments

@yevgenypats
Copy link

Hey there, found the following bug/infinite loop/oom that can be reproduced with the following code:

const jpeg = require('jpeg-js');
jpeg.decode(Buffer.from('ffd8ffc09dfdb0ffff0e5296bd7fbbc4f9579096bd7fbbfc0e80d50000ffff36fa400100236701bf73ffaf8003a57f097f5e000000008023c4f9579096bd7fbb008000001500b34e8c018fda5212', 'hex'))

found using jsfuzz
@patrickhulce
Copy link
Collaborator

Thanks @yevgenypats! :)

@yevgenypats
Copy link
Author

@patrickhulce sure!:)

@patrickhulce patrickhulce mentioned this issue Oct 21, 2019
Closed
@metabench
Copy link

metabench commented Oct 31, 2019 •
edited
Loading

@yevgenypats Do you know any more about the specifics of this bug? Is there any more detail you can give about how you used jsfuzz to find it, what you were looking for, what jsfuzz did to find it etc. No worries if these details are not available, it's useful to know of the bug. Thanks for reporting it.

@patrickhulce 'not really going to try to close all of these holes' from the PR. How about assisting with the creation of new algorithms that don't have these bugs, either in a new branch of this project, or directing people to the project I'm working on (or at least allowing me to talk about it within jpeg-js discussions). jpeg-js is well known and strong through the network effect, and longer term I see a route where with your support jpeg-js can improve.

@patrickhulce
Copy link
Collaborator

this has been fixed by #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support conservative memory limits jpeg-js/jpeg-js
3 participants
@metabench @patrickhulce @yevgenypats