Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jquense/yup
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.1.0
Choose a base ref
...
head repository: jquense/yup
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.1.1
Choose a head ref
  • 5 commits
  • 11 files changed
  • 3 contributors

Commits on Apr 12, 2023

  1. Configuration menu
    Copy the full SHA
    4ed4576 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. fix: make null validation errors consistent across schema (#1982)

    Previously, schema that parse to invalid values like InvalidDate or NaN always tripped the typeError validation before the nullability error. This was the due to typeError no longer firing on null values, with the expectation that it would always hit the newer nullability check.
    
    This change fixes the issue for Number and Date schema, so that they act the same as String and other schema, where null values do not trigger the typeError validation. The consequence of this is that casting null values for non-nullable number schema, now return null instead of NaN and dates, return null instead of InvalidDate. Essentially these schema will not fruitlessly attempt to coerce null into a number or date anymore.
    
    I am marking this as a bug fix since it is, and as with most bug fixes, could also be considered a breaking change. I'm going to optimistically not cut a v2 for this. If you have unexpected changes it is likely due to number/date schema hitting different validation errors (nullability).
    
    Previously for these schema it was common practice to change the typeError for these schema to something like "this is required"assuming the issue was due to invalid nulls. NOW the schema will show the locale.notNull message, so if you may want to adjust that to something more user friendly if you surface default locale messages to users (we don't generally recommend that).
    jquense authored Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f999497 View commit details
    Browse the repository at this point in the history
  2. fix(object): excluded edges are merged when concating schema

    fixes #1969
    jquense committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    c07b08f View commit details
    Browse the repository at this point in the history
  3. add test

    jquense committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    11d860a View commit details
    Browse the repository at this point in the history
  4. Publish v1.1.1

    jquense committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    1086aa9 View commit details
    Browse the repository at this point in the history
Loading