Skip to content

Update ESLint on main to >=9.20.1 #5629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mgol opened this issue Feb 13, 2025 · 3 comments
Open

Update ESLint on main to >=9.20.1 #5629

mgol opened this issue Feb 13, 2025 · 3 comments
Assignees
@timmywil
Labels
4.x-only Build

Comments

@mgol
Copy link
Member

mgol commented Feb 13, 2025

Description

We currently use a ESLint v9 on 3.x-stable but we still use v8 on main. This was because we were blocked on eslint-plugin-import supporting the flat config. That has since been resolved (see import-js/eslint-plugin-import#2556) and we should update.

Link to test case

N/A
@timmywil
Copy link
Member

The issue you linked is not what needed to be resolved. eslint 9 support was separate from flat config support. The appropriate issue is import-js/eslint-plugin-import#2948, and while that was resolved, I think there's still an issue with the no-unused-imports rule, which was the main rule I was waiting for. See import-js/eslint-plugin-import#3079 and import-js/eslint-plugin-import#2678

@mgol
Copy link
Member Author

mgol commented Feb 13, 2025

Thanks for the info. I don't think import-js/eslint-plugin-import#2678 blocks us but import-js/eslint-plugin-import#3079 definitely does. Let's track this one.

@mgol
Copy link
Member Author

mgol commented Feb 13, 2025

Actually, scratch that, both are relevant.

BTW, I was following the comment above the commented our rule; it seems it's incorrect then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timmywil timmywil

Labels
4.x-only Build
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timmywil @mgol