[WIP] Event: Use one native handler per jQuery handler #3127
+65
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests are still failing, need to fix propagation issues
|
|
||
| if ( elem.addEventListener ) { | ||
| elem.addEventListener( type, eventHandle ); | ||
| elem.addEventListener( type, handleObj ); |
There was a problem hiding this comment.
This is still guarded by:
if ( !( handlers = events[ type ] ) ) {making it one addEventListener per event type... Or am I reading it wrong?
There was a problem hiding this comment.
Hmm, I'll definitely look into that. Seems like a LOT of stuff should have broken.
|
@dmethvin was it supposed to get closed? I suppose not as it still has a milestone so I'm reopening it. |
|
Looks like I accidentally deleted the fork in August which closed it, so yeah it should still be open. |
|
Closing & re-opening the PR to trigger the EasyCLA check... |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is definitely a v4 kind of thing with breaking changes and it still needs more work before it passes tests, but I'll post it here in case anyone has thoughts or comments.
EDIT: All my comments from below are in my fork, dmethvin@113ce67