Updates one test so that it can run on Windows

garethellis36 · garethellis36 · commit 1790c48174e2 · 2016-09-08T11:14:11.000+01:00
diff --git a/tests/HelperTest.php b/tests/HelperTest.php
@@ -25,6 +25,11 @@ class HelperTest extends \PHPUnit_Framework_TestCase
      */
     private $lockFile;
 
+    /**
+     * @var string
+     */
+    private $copyOfLockFile;
+
     /**
      * {@inheritdoc}
      */
@@ -33,6 +38,7 @@ protected function setUp()
         $this->helper = new Helper();
         $this->tmpDir = $this->helper->getTempDir();
         $this->lockFile = $this->tmpDir . '/test.lock';
+        $this->copyOfLockFile = $this->tmpDir . "/test.lock.copy";
     }
 
     /**
@@ -105,12 +111,18 @@ public function testAquireAndReleaseLock()
      */
     public function testLockFileShouldContainCurrentPid()
     {
+        $this->helper->acquireLock($this->lockFile);
+
+        //on Windows, file locking is mandatory not advisory, so you can't do file_get_contents on a locked file
+        //therefore, we need to make a copy of the lock file in order to read its contents
         if ($this->helper->getPlatform() === Helper::WINDOWS) {
-            $this->markTestSkipped("Unable to read a locked file on Windows");
+            copy($this->lockFile, $this->copyOfLockFile);
+            $lockFile = $this->copyOfLockFile;
+        } else {
+            $lockFile = $this->lockFile;
         }
 
-        $this->helper->acquireLock($this->lockFile);
-        $this->assertEquals(getmypid(), file_get_contents($this->lockFile));
+        $this->assertEquals(getmypid(), file_get_contents($lockFile));
 
         $this->helper->releaseLock($this->lockFile);
         $this->assertEmpty(file_get_contents($this->lockFile));
@@ -154,7 +166,7 @@ public function testLockLifetimeShouldBeZeroIfItContainsAInvalidPid()
     public function testGetLocklifetime()
     {
         if ($this->helper->getPlatform() === Helper::WINDOWS) {
-            $this->markTestSkipped("Unable to read a locked file on Windows");
+            $this->markTestSkipped("Test relies on posix_ functions");
         }
 
         $this->helper->acquireLock($this->lockFile);
